stdenv.mkDerivation: check that depsBuildX are executable on the build system by Artturin · Pull Request #204387 · NixOS/nixpkgs

Artturin · 2022-12-04T01:23:51Z

nix-repl> :p pkgsCross.aarch64-multiplatform.keybinder.nativeBuildInputs
[ «derivation /nix/store/sxxk0g9gd18w9r28gbfx8wl65sr8liwm-aarch64-unknown-linux-gnu-pkg-config-wrapper-0.29.2.drv» «derivation /nix/store/ldbs4pw57hy3szqfh8ycskrgywpaahqs-autoconf-2.71.drv» trace: warning: automake-aarch64-unknown-linux-gnu-1.11.6 in keybinder nativeBuildInputs not executable on build
«derivation /nix/store/yj8vj3gbd78scrj4xjmdx4rm5p87dyb9-automake-aarch64-unknown-linux-gnu-1.11.6.drv» ]

TODO less duplication and better warning by merging with checkDependencyList/make a function which takes these as args

SuperSandro2000 · 2022-12-04T01:52:17Z

There seems to be a lot of errors around i686-w64-mingw32-stage-final-gcc-wrapper but I like the general idea.

Artturin · 2022-12-04T02:40:26Z

nix-repl> o = lib.lists.last wine.nativeBuildInputs

nix-repl> o
«derivation /nix/store/i7ya4lqal0awbgxrabkq70gx56skvax5-i686-w64-mingw32-stage-final-gcc-wrapper-11.3.0.drv»

nix-repl> stdenv.buildPlatform.canExecute o.stdenv.hostPlatform
true

nix-repl> pkgsi686Linux.stdenv.buildPlatform.canExecute o.stdenv.hostPlatform
false

wine64 and wineWowPackages.full eval while wine(wine32) failsto eval

nixpkgs/pkgs/applications/emulators/wine/packages.nix

Line 11 in 880d998

wine32 = pkgsi686Linux.callPackage ./base.nix {

Artturin · 2022-12-04T03:18:42Z

this fixes the eval error, i copied it from wineWow

diff --git a/pkgs/applications/emulators/wine/packages.nix b/pkgs/applications/emulators/wine/packages.nix
index 3b5aa19658c..440fd167d98 100644
--- a/pkgs/applications/emulators/wine/packages.nix
+++ b/pkgs/applications/emulators/wine/packages.nix
@@ -11,6 +11,7 @@ in with src; {
   wine32 = pkgsi686Linux.callPackage ./base.nix {
     pname = "wine";
     inherit src version supportFlags patches moltenvk;
+    stdenv = stdenv_32bit;
     pkgArches = [ pkgsi686Linux ];
     vkd3dArches = lib.optionals supportFlags.vkd3dSupport [ vkd3d_i686 ];
     geckos = [ gecko32 ];

but it does change

checking build system type... i686-pc-linux-gnu
checking host system type... i686-pc-linux-gnu

to

wine> checking build system type... x86_64-pc-linux-gnu
wine> checking host system type... x86_64-pc-linux-gnu

# A stdenv capable of building 32-bit binaries.
# On x86_64-linux, it uses GCC compiled with multilib support; on i686-linux,
# it's just the plain stdenv.
stdenv_32bit = lowPrio (if stdenv.hostPlatform.is32bit then stdenv else multiStdenv);

i don't know if this affects anything negatively but wine builds and the log output is similar but with stuff like gcc -m32 ... and -m32 in other places

Weird things in the log are

checking for cups/cups.h... yes
checking for cups/ppd.h... yes
- checking for -lcups... libcups.so.2
+ checking for -lcups... not found
...
- configure: libcapi20 development files not found, ISDN won't be supported.
+ configure: libcapi20 32-bit development files not found, ISDN won't be supported.
+ configure: libcups 32-bit development files not found, CUPS won't be supported.

no diff in

nix-repl> pkgs = import ./. { system = "i686-linux"; }

nix-repl> pkgs.wine
«derivation /nix/store/lik48akxk5hk3hvbqhaxgsh0827kv3zd-wine-7.0.drv»

Artturin · 2022-12-05T01:20:08Z

lots of warnings in perlPackages and pythonPackages
pythonPackages fix in #201734

perlPackages todo for me, will be fixed before this pr is merged or in this pr

Artturin · 2022-12-05T01:21:41Z

pkgs/development/interpreters/perl/default.nix

preparation for doing splicing like in python

Artturin · 2022-12-05T17:16:32Z

somehow the mini output of perl gets introduced

before

nix-repl> pkgsCross.aarch64-multiplatform.buildPackages.perlPackages.perl.mini
error: attribute 'mini' missing

       at «string»:1:1: (source not available)
       Did you mean man?

nix-repl> pkgsCross.aarch64-multiplatform.buildPackages.perlPackages.perl
«derivation /nix/store/bjh5sr9f1g48q1by44qnabgkdiayi5h9-perl-5.36.0.drv»

after

nix-repl> pkgsCross.aarch64-multiplatform.buildPackages.perlPackages.perl.mini
«derivation /nix/store/x873z4mmfqwynw10a8j5v9xzm8mharsk-perl-aarch64-unknown-linux-gnu-5.36.0.drv»

nix-repl> pkgsCross.aarch64-multiplatform.buildPackages.perlPackages.perl
«derivation /nix/store/bjh5sr9f1g48q1by44qnabgkdiayi5h9-perl-5.36.0.drv»

dropping perl: use self == __splicedPackages instead of perl and buildPerl from this PR

EDIT: added it back and used (perl.__spliced.buildHost.mini or perl)

to make sure all things in nativeBuildInputs are executable on buildPlatform ``` checking build system type... i686-pc-linux-gnu checking host system type... i686-pc-linux-gnu ``` to ``` wine> checking build system type... x86_64-pc-linux-gnu wine> checking host system type... x86_64-pc-linux-gnu ``` i don't know if this affects anything negatively but wine builds and the log output is similar but with stuff like `gcc -m32 ...` and `-m32` in other places Weird things in the log are ```diff checking for cups/cups.h... yes checking for cups/ppd.h... yes - checking for -lcups... libcups.so.2 + checking for -lcups... not found ... - configure: libcapi20 development files not found, ISDN won't be supported. + configure: libcapi20 32-bit development files not found, ISDN won't be supported. + configure: libcups 32-bit development files not found, CUPS won't be supported. ``` no diff in ``` nix-repl> pkgs = import ./. { system = "i686-linux"; } nix-repl> pkgs.wine «derivation /nix/store/lik48akxk5hk3hvbqhaxgsh0827kv3zd-wine-7.0.drv» ```

["trace: warning: dpkg-1.21.1ubuntu2.1 in mfcl3770cdwdrv-1.0.2-0 nativeBuildInputs not executable on build", "trace: warning: hook in mfcl3770cdwdrv-1.0.2-0 nativeBuildInputs not executable on build", "trace: warning: dpkg-1.21.1ubuntu2.1 in mfcl3770cdwdrv-1.0.2-0 nativeBuildInputs not executable on build", "trace: warning: hook in mfcl3770cdwdrv-1.0.2-0 nativeBuildInputs not executable on build"] ``` nix-repl> o = lib.lists.last wine.nativeBuildInputs nix-repl> o «derivation /nix/store/i7ya4lqal0awbgxrabkq70gx56skvax5-i686-w64-mingw32-stage-final-gcc-wrapper-11.3.0.drv» nix-repl> stdenv.buildPlatform.canExecute o.stdenv.hostPlatform true nix-repl> pkgsi686Linux.stdenv.buildPlatform.canExecute o.stdenv.hostPlatform false ```

allows us to use nixpkgs-fmt when editing this file making the editing experience much better

…d system ``` nix-repl> pkgsCross.aarch64-multiplatform.keybinder.nativeBuildInputs [ «derivation /nix/store/sxxk0g9gd18w9r28gbfx8wl65sr8liwm-aarch64-unknown-linux-gnu-pkg-config-wrapper-0.29.2.drv» «derivation /nix/store/ldbs4pw57hy3szqfh8ycskrgywpaahqs-autoconf-2.71.drv» trace: warning: automake-aarch64-unknown-linux-gnu-1.11.6 in keybinder's nativeBuildInputs not executable on build «derivation /nix/store/yj8vj3gbd78scrj4xjmdx4rm5p87dyb9-automake-aarch64-unknown-linux-gnu-1.11.6.drv» ] ```

ghost · 2023-10-24T07:27:59Z

You can ping me for a review when this is ready.

Checking for this kind of stuff is a good idea in general.

Artturin requested review from Ericson2314 and matthewbauer as code owners December 4, 2022 01:23

Artturin marked this pull request as draft December 4, 2022 01:23

github-actions bot added the 6.topic: stdenv Standard environment label Dec 4, 2022

Artturin force-pushed the checkdepsbuildexecutableonbuild branch 2 times, most recently from c94d3c8 to 2c20464 Compare December 4, 2022 13:45

github-actions bot added the 6.topic: printing Drivers, CUPS & Co. label Dec 4, 2022

ofborg bot requested a review from steveej December 4, 2022 15:00

ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Dec 4, 2022

Artturin force-pushed the checkdepsbuildexecutableonbuild branch 3 times, most recently from ac9207b to aa8cc54 Compare December 5, 2022 00:16

Artturin changed the title ~~WIP stdenv.mkDerivation: check that depsBuildX are executable on the …~~ stdenv.mkDerivation: check that depsBuildX are executable on the build system Dec 5, 2022

Artturin force-pushed the checkdepsbuildexecutableonbuild branch from aa8cc54 to 823846c Compare December 5, 2022 00:47

Artturin commented Dec 5, 2022

View reviewed changes

pkgs/development/interpreters/perl/default.nix Outdated

Copy link

Member Author

Artturin Dec 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preparation for doing splicing like in python

Artturin force-pushed the checkdepsbuildexecutableonbuild branch 3 times, most recently from 9b31a18 to cb459fb Compare December 5, 2022 16:50

Artturin force-pushed the checkdepsbuildexecutableonbuild branch 3 times, most recently from 7b7fa24 to 2ae9d60 Compare December 5, 2022 18:00

Artturin mentioned this pull request Dec 31, 2022

nativeBuildInputs gives non native dependencies when used with overrides in all-packages.nix #49526

Open

Artturin force-pushed the checkdepsbuildexecutableonbuild branch from 2ae9d60 to ca669f8 Compare January 8, 2023 19:25

Artturin added 6 commits January 8, 2023 21:48

pkgs/stdenv/generic/make-derivation.nix: run nixpkgs-fmt

fc073c4

allows us to use nixpkgs-fmt when editing this file making the editing experience much better

perl: use self == __splicedPackages instead of perl and buildPerl

7e23b3b

stdenv.mkDerivation: workaround hacks in perl cross-compilation

27bc9f4

stdenv.mkDerivation: workaround

6e027e0

Artturin force-pushed the checkdepsbuildexecutableonbuild branch from ca669f8 to 6e027e0 Compare January 8, 2023 19:50

Artturin mentioned this pull request Apr 25, 2023

python: don't use keep for hooks, so they will be spliced #228139

Draft

12 tasks

Artturin mentioned this pull request Oct 24, 2023

make-derivation.nix: lib.warn if drv.__spliced missing #263082

Closed

2 tasks

wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict This PR has merge conflicts with the target branch labels Mar 19, 2024

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024

wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

stdenv.mkDerivation: check that depsBuildX are executable on the build system#204387

stdenv.mkDerivation: check that depsBuildX are executable on the build system#204387
Artturin wants to merge 7 commits intoNixOS:masterfrom
Artturin:checkdepsbuildexecutableonbuild

Artturin commented Dec 4, 2022 •

edited

Loading

Uh oh!

SuperSandro2000 commented Dec 4, 2022

Uh oh!

Artturin commented Dec 4, 2022 •

edited

Loading

Uh oh!

Artturin commented Dec 4, 2022 •

edited

Loading

Uh oh!

Artturin commented Dec 5, 2022

Uh oh!

Artturin Dec 5, 2022

Uh oh!

Artturin commented Dec 5, 2022 •

edited

Loading

Uh oh!

ghost commented Oct 24, 2023 •

edited by ghost

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Artturin commented Dec 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SuperSandro2000 commented Dec 4, 2022

Uh oh!

Artturin commented Dec 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Artturin commented Dec 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Artturin commented Dec 5, 2022

Uh oh!

Artturin Dec 5, 2022

Choose a reason for hiding this comment

Uh oh!

Artturin commented Dec 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Oct 24, 2023 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Artturin commented Dec 4, 2022 •

edited

Loading

Artturin commented Dec 4, 2022 •

edited

Loading

Artturin commented Dec 4, 2022 •

edited

Loading

Artturin commented Dec 5, 2022 •

edited

Loading

ghost commented Oct 24, 2023 •

edited by ghost

Loading