Skip to content

citations: init at 0.5.1#202605

Merged
jtojnar merged 2 commits intoNixOS:masterfrom
BenediktBroich:citations
Dec 13, 2022
Merged

citations: init at 0.5.1#202605
jtojnar merged 2 commits intoNixOS:masterfrom
BenediktBroich:citations

Conversation

@BenediktBroich
Copy link
Contributor

@BenediktBroich BenediktBroich commented Nov 23, 2022 •
edited
Loading

Description of changes

Add a new package named citations.

Homepage
Source

How to test this change?

Build: nix-shell -p nixpkgs-review --run "nixpkgs-review pr 202605"
Run application: citations
Run test: nix-build -A citations.passthru.tests or nix-build -A citations.passthru.tests.version

WARNING! DON'T open a existing .bib file without a backup. The Application does not support comments and might be lost.

Example Testing

  1. touch test.bib
  2. Open the database file.
  3. Add citations using the ui
  4. Open the database file with a text editor to see the bibtex format
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 23, 2022
@nixos-discourse
Copy link

nixos-discourse commented Nov 24, 2022

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nixpkgs-pull-request-ask-for-instructions-to-test/23449/1

@BenediktBroich BenediktBroich force-pushed the citations branch 3 times, most recently from ac211d4 to 3e01723 Compare November 25, 2022 22:26
@BenediktBroich BenediktBroich mentioned this pull request Dec 8, 2022
Closed
31 tasks
jtojnar
jtojnar reviewed Dec 8, 2022
View reviewed changes
jtojnar
jtojnar reviewed Dec 8, 2022
View reviewed changes
@BenediktBroich
Copy link
Contributor Author

BenediktBroich commented Dec 9, 2022

Result of nixpkgs-review pr 202605 run on x86_64-linux 1

1 package built:
  • citations

@BenediktBroich BenediktBroich force-pushed the citations branch 8 times, most recently from 8e0962e to bc93382 Compare December 12, 2022 20:03
@nixos-discourse
Copy link

nixos-discourse commented Dec 13, 2022

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1547

SuperSandro2000
SuperSandro2000 reviewed Dec 13, 2022
View reviewed changes
jtojnar
jtojnar reviewed Dec 13, 2022
View reviewed changes
@jtojnar jtojnar merged commit 41c8ece into NixOS:master Dec 13, 2022
@BenediktBroich BenediktBroich deleted the citations branch December 13, 2022 20:12
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@jtojnar jtojnar jtojnar approved these changes

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BenediktBroich @nixos-discourse @jtojnar @SuperSandro2000 @Janik-Haag