Skip to content

glib: Fix infinite loop in GNOME Keyring#201229

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
jtojnar:glib-fix-keyring
Nov 15, 2022
Merged

glib: Fix infinite loop in GNOME Keyring#201229
vcunat merged 1 commit intoNixOS:staging-nextfrom
jtojnar:glib-fix-keyring

Conversation

@jtojnar
Copy link
Member

@jtojnar jtojnar commented Nov 14, 2022

Description of changes

This was a regression in GLib 2.74.1:

https://gitlab.gnome.org/GNOME/gnome-keyring/-/issues/123

cc @vcunat

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar mentioned this pull request Nov 14, 2022
13 tasks
@MrTarantoga
Copy link
Contributor

Same error here

@vcunat
Copy link
Member

vcunat commented Nov 15, 2022

How urgent is this? From a quick glance on a previous glib-only PR, the total rebuild amount could be like 57k.

@MrTarantoga
Copy link
Contributor

How urgent is this? From a quick glance on a previous glib-only PR, the total rebuild amount could be like 57k.

Well, my gnome-keyring is on all machines all-time at 100%. I cannot disable it, because I need the VPN which depends on. On laptop battery drain is very high.

I would be very appreciated if someone add the fix soon.

@jtojnar
Copy link
Member Author

jtojnar commented Nov 15, 2022

Likely affects all users of GNOME, Pantheon, Cinnamon and MATE desktop environments and Evolution or Geary e-mail clients and then some.

@vcunat vcunat merged commit 1f4c790 into NixOS:staging-next Nov 15, 2022
@jtojnar jtojnar deleted the glib-fix-keyring branch November 15, 2022 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants