Skip to content

gi-docgen: 2022.1 → 2022.2#200775

Merged
jtojnar merged 1 commit intoNixOS:stagingfrom
jtojnar:gi-docgen
Nov 16, 2022
Merged

gi-docgen: 2022.1 → 2022.2#200775
jtojnar merged 1 commit intoNixOS:stagingfrom
jtojnar:gi-docgen

Conversation

@jtojnar
Copy link
Member

@jtojnar jtojnar commented Nov 11, 2022

Description of changes

https://gitlab.gnome.org/GNOME/gi-docgen/-/tags/2022.2

Switch to GNOME mirror and add update script.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Nov 12, 2022
@dasj19
Copy link
Contributor

dasj19 commented Nov 12, 2022

nix-review fails on this. tried twice.

nix-review pr 200775
$ git -c fetch.prune=false fetch --no-tags --force https://github.com/NixOS/nixpkgs staging:refs/nixpkgs-review/0 pull/200775/head:refs/nixpkgs-review/1
$ git worktree add /home/daniel/.cache/nixpkgs-review/pr-200775-1/nixpkgs 9295782ba2588b1e3587f9e1aa8ac273dd4b068d
Preparing worktree (detached HEAD 9295782ba25)
Updating files: 100% (32696/32696), done.
HEAD is now at 9295782ba25 Merge staging-next into staging
$ git merge --no-commit --no-ff fb213161c307649ad2a1987de861ad0a48bcc097
Automatic merge went well; stopped before committing as requested
error: Function called without required argument "kdialog" at /home/daniel/.cache/nixpkgs-review/pr-200775-1/nixpkgs/pkgs/applications/backup/ludusavi/default.nix:16, did you mean "dialog", "gtdialog" or "gtkdialog"?
(use '--show-trace' to show detailed location information)
nix --experimental-features nix-command --system x86_64-linux eval --json --impure --expr (import /nix/store/nci1s3y693yifx3kqg0cd81p8alybnqk-nixpkgs-review-2.7.0/lib/python3.10/site-packages/nixpkgs_review/nix/evalAttrs.nix { allowAliases = false; attr-json = /tmp/tmppt40734n; }) failed to run, /tmp/tmppt40734n was stored inspection
https://github.com/NixOS/nixpkgs/pull/200775 failed to build
$ git worktree prune

@jtojnar
Copy link
Member Author

jtojnar commented Nov 12, 2022

That does not look related.

@amaxine
Copy link
Contributor

amaxine commented Nov 12, 2022

Rebasing on latest staging has no such failure.

@jtojnar jtojnar mentioned this pull request Nov 16, 2022
Closed
13 tasks
@jtojnar jtojnar merged commit 34d3da7 into NixOS:staging Nov 16, 2022
@jtojnar jtojnar deleted the gi-docgen branch November 16, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dasj19 dasj19 Awaiting requested review from dasj19

@bobby285271 bobby285271 Awaiting requested review from bobby285271

@hedning hedning Awaiting requested review from hedning

1 more reviewer

@amaxine amaxine amaxine approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtojnar @dasj19 @amaxine