Skip to content

humility: update libusb alias and vendor hash#199794

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
tjni:fix-humility-hash
Nov 10, 2022
Merged

humility: update libusb alias and vendor hash#199794
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
tjni:fix-humility-hash

Conversation

@tjni
Copy link
Contributor

@tjni tjni commented Nov 6, 2022

Description of changes

I do not know why the hash is wrong, but it is not just failing locally for me but also on Hydra.

This was affecting a nixpkgs-review run I was doing. It supersedes #198673 and fixes #192842.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from therishidesai November 6, 2022 00:57
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 6, 2022
@tjni tjni marked this pull request as draft November 6, 2022 01:22
@tjni
Copy link
Contributor Author

tjni commented Nov 6, 2022

There's a dependency on libftdi, which is failing to build on master on x86_64-darwin. I'm bisecting right now using a GitHub Actions runner, but it's slow going.

@tjni
Copy link
Contributor Author

tjni commented Nov 9, 2022

I wasn't able to bisect it successfully, but #200322 ought to fix it.

@tjni tjni mentioned this pull request Nov 9, 2022
Merged
13 tasks
@tjni tjni marked this pull request as ready for review November 10, 2022 04:08
@nixos-discourse
Copy link

nixos-discourse commented Nov 10, 2022

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1394

@kevincox
Copy link
Contributor

kevincox commented Nov 10, 2022

Result of nixpkgs-review pr 199794 run on x86_64-linux 1

1 package built:
  • humility

@kevincox
Copy link
Contributor

kevincox commented Nov 10, 2022

I've give a day or so for the maintainer to review but other than that it looks good.

@SuperSandro2000 SuperSandro2000 merged commit 717ccac into NixOS:master Nov 10, 2022
@tjni tjni deleted the fix-humility-hash branch November 10, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevincox kevincox kevincox approved these changes

@therishidesai therishidesai Awaiting requested review from therishidesai

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tjni @nixos-discourse @kevincox @SuperSandro2000