lib,doc: remove obvious usages of toString on paths#199772
Merged
AndersonTorres merged 1 commit intoNixOS:masterfrom Nov 5, 2022
Merged
lib,doc: remove obvious usages of toString on paths#199772AndersonTorres merged 1 commit intoNixOS:masterfrom
AndersonTorres merged 1 commit intoNixOS:masterfrom
Conversation
Artturin
requested review from
edolstra,
fricklerhandwerk,
infinisil and
nbp
as code owners
github-actions
bot
added
the
8.has: documentation
It gives a warning on the lazy-trees branch of Nix (NixOS/nix#6530) one of these was also giving me an error (the one in lib/trivial probably) ``` $ nix build warning: applying 'toString' to path '/home/artturin/nixgits/my-nixpkgs/nixos/modules/installer/sd-card/sd -image-aarch64.nix' and then accessing it is deprecated, at /home/artturin/nixgits/my-nixpkgs/lib/modules. nix:349:99 warning: applying 'toString' to path '/home/artturin/nixgits/my-nixpkgs/.git' and then accessing it is dep recated, at /home/artturin/nixgits/my-nixpkgs/lib/sources.nix:35:32 warning: applying 'toString' to path '/home/artturin/nixgits/my-nixpkgs/nixos/modules/system/etc/etc.nix' and then accessing it is deprecated, at «stdin»:0 warning: applying 'toString' to path '/home/artturin/nixgits/my-nixpkgs/nixos/modules/system/etc/etc-activ ation.nix' and then accessing it is deprecated, at «stdin»:0 warning: applying 'toString' to path '/home/artturin/nixgits/my-nixpkgs/nixos/modules/installer/sd-card/sd -image-aarch64.nix' and then accessing it is deprecated, at «stdin»:0 error: cannot decode virtual path '/nix/store/virtual0000000000000000000000005-source' (use '--show-trace' to show detailed location information) ```
Artturin
force-pushed
the
removeusagesoftostringonpath
branch
from
2a8d673 to
66cf79f
Compare
ofborg
bot
added
10.rebuild-darwin: 0
Contributor
|
I can't build my system with this commit in: |
Member
OK, reverting. |
Member
Author
|
Retry #199812 |
ncfavier
reviewed
Nov 9, 2022
| in lib.cleanSourceWith { | ||
| filter = (path: type: | ||
| let relPath = lib.removePrefix (toString origSrc + "/") (toString path); | ||
| let relPath = lib.removePrefix (origSrc + "/") (path); |
Member
There was a problem hiding this comment.
??
removePrefix doesn't work on paths, does it? Won't this copy every single path to the store?
EDIT: ah, this was reverted
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It gives a warning on the lazy-trees branch of Nix (NixOS/nix#6530)
one of these was also giving me an error (the one in lib/trivial probably)
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes