Skip to content

procps: 3.3.16 -> 3.3.17#199513

Merged
marsam merged 1 commit intoNixOS:stagingfrom
aaronjheng:procps
Nov 13, 2022
Merged

procps: 3.3.16 -> 3.3.17#199513
marsam merged 1 commit intoNixOS:stagingfrom
aaronjheng:procps

Conversation

@aaronjheng
Copy link
Contributor

@aaronjheng aaronjheng commented Nov 4, 2022 •
edited
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from typetetris November 4, 2022 12:06
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Nov 4, 2022
@ck3d
Copy link
Contributor

ck3d commented Nov 5, 2022

You should target branch staging

@aaronjheng aaronjheng changed the base branch from master to staging November 5, 2022 23:56
@aaronjheng
Copy link
Contributor Author

aaronjheng commented Nov 6, 2022

Done.

@marsam
Copy link
Contributor

marsam commented Nov 13, 2022

Shall we update it to 4.0.1 https://gitlab.com/procps-ng/procps/-/tags/v4.0.1?

@aaronjheng
Copy link
Contributor Author

aaronjheng commented Nov 13, 2022

V4 has some breaking changes. I think it's better to add a versioned package, like procps4.

@marsam marsam merged commit 264b2d1 into NixOS:staging Nov 13, 2022
@aaronjheng aaronjheng deleted the procps branch November 13, 2022 12:56
@yu-re-ka yu-re-ka mentioned this pull request Dec 3, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@typetetris typetetris Awaiting requested review from typetetris

Assignees

No one assigned

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aaronjheng @ck3d @marsam