You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages
Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
Tested basic functionality of all binary files (usually in ./result/bin/)
@tobim Any thoughts here? I'm not sure how to proceed. A bunch of the failed to build packages are failing on master, and some of them (👀 tensorflow) I can't reliably build on my (fairly beefy: 16-core-32-thread + 64GB) desktop.
I guess I'll just run my own script to build each of those packages against master and then the branch so I can see which ones' failures are caused by this PR.
Seems like the only way this builds successfully is by explicitly setting -DCMAKE_CXX_STANARD=17 in grpc and google-cloud-cpp, but that also appears to break aarch64 builds and darwin builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10.rebuild-darwin: 101-500This PR causes between 101 and 500 packages to rebuild on Darwin.10.rebuild-linux: 501-1000This PR causes many rebuilds on Linux and should normally target the staging branches.10.rebuild-linux: 501+This PR causes many rebuilds on Linux and should normally target the staging branches.11.by: package-maintainerThis PR was created by a maintainer of all the package it changes.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Bumps google-cloud-cpp to 2.4.0.
Still need to test downstream packages.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes