eduke32: fix build by removing explicit header paths#198019
Merged
trofi merged 1 commit intoNixOS:masterfrom Oct 27, 2022
Merged
eduke32: fix build by removing explicit header paths#198019trofi merged 1 commit intoNixOS:masterfrom
trofi merged 1 commit intoNixOS:masterfrom
Conversation
In NixOS#197798 (comment) we noticed that `eduke32` fails to build as: source/build/include/sdl_inc.h:17:12: fatal error: SDL2/SDL.h: No such file or directory 17 | # include <SDL2/SDL.h> | ^~~~~~~~~~~~ It statred after NixOS#191724 where `NIX_CFLAGS_COMPILE` entries were cleaned up slightly. This change works build failure around. But I think it's a good change: there should be no reason to set SDL2 offset via forced include paths.
13 tasks
ofborg
bot
added
10.rebuild-darwin: 1-10
Member
mikroskeem
approved these changes
Oct 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #197798 (comment) we noticed that
eduke32fails to build as:It statred after #191724 where
NIX_CFLAGS_COMPILEentries were cleaned up slightly.This change works build failure around. But I think it's a good change: there should be no reason to set SDL2 offset via forced include paths.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes