Skip to content

webp-pixbuf-loader: Adopt by GNOME#197029

Merged
jtojnar merged 7 commits intoNixOS:masterfrom
jtojnar:webp-loader
Oct 25, 2022
Merged

webp-pixbuf-loader: Adopt by GNOME#197029
jtojnar merged 7 commits intoNixOS:masterfrom
jtojnar:webp-loader

Conversation

@jtojnar
Copy link
Member

@jtojnar jtojnar commented Oct 21, 2022 •
edited
Loading

Description of changes

GNOME uses this for backgrounds so let’s add GNOME team to maintainers and adopt GNOME coding style aimed at cleaner git diffs.

Also add into GNOME packages so that gnome-backgrounds 43 work.

Fixes: #196428

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
    • gnome-control-center displays WebP backgrounds
    • GNOME Shell displays WebP backgrounds
    • Nautilus thumbnails WebP images
    • eog can view WebP files
    • Nautilus “set background” dialogue (GNOME portal) previews WebP files
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Oct 21, 2022
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 21, 2022
@jtojnar
webp-pixbuf-loader: Adopt by GNOME
f19bcee 
GNOME uses this for backgrounds so let’s add GNOME team to maintainers
and adopt GNOME coding style aimed at cleaner git diffs:

- Format with `nixpkgs-fmt`
- Inherit `moduleDir` variable since it has the same name
- Avoid re-using `pname` for `src` in case it is overwritten
- Use conventional attribute ordering
- Have one dependency per line in inputs
- Move comments closer to what they describe
- Wrap long substitute line
- Quote bash values
@jtojnar
gnome.nautilus: Support thumbnailing WebP files
4fb7c5f 
Note that no other GNOME apps currently support WebP on NixOS
because we lack a usable composition method for gdk-pixbuf caches.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 21, 2022
@jtojnar jtojnar force-pushed the webp-loader branch 2 times, most recently from 1386eca to fe754d3 Compare October 21, 2022 07:55
@jtojnar jtojnar requested a review from romildo October 21, 2022 07:56
@jtojnar
gnome._gdkPixbufCacheBuilder_DO_NOT_USE: Extract from nixos/gdk-pixbuf
c789af6 
Unlike previously, we now fail loudly when a package not containing a gdk-pixbuf modules is passed.
@jtojnar jtojnar marked this pull request as draft October 21, 2022 08:07
@ofborg ofborg bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 21, 2022
@jtojnar
xdg-desktop-portal-gnome: Support WebP files
7140875 
A hack until gdk-pixbuf learns to support multiple cache files.
@jtojnar
gnome.gnome-shell: Support WebP files
e674c5b 
A hack until gdk-pixbuf learns to support multiple cache files.
@jtojnar
gnome.gnome-control-center: Support WebP files
b6804f7 
A hack until gdk-pixbuf learns to support multiple cache files.
@jtojnar
gnome.eog: Support WebP files
a8e1949 
A hack until gdk-pixbuf learns to support multiple cache files.
@jtojnar jtojnar marked this pull request as ready for review October 21, 2022 08:42
This was referenced Oct 21, 2022
Merged
Draft
@jtojnar jtojnar merged commit 361d986 into NixOS:master Oct 25, 2022
@jtojnar jtojnar deleted the webp-loader branch October 25, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cwyc cwyc Awaiting requested review from cwyc

@hedning hedning Awaiting requested review from hedning

@bobby285271 bobby285271 Awaiting requested review from bobby285271

@dasj19 dasj19 Awaiting requested review from dasj19

@amaxine amaxine Awaiting requested review from amaxine

@romildo romildo Awaiting requested review from romildo

Assignees

No one assigned

Labels

6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

webp backgrounds are broken in gnome 43

1 participant

@jtojnar