Conversation
7399335 to
6f0a186
Compare
|
Thank you for the fix! |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
6f0a186 to
1c11d8d
Compare
|
After upgrading to the latest version opening project containing kotlin files make idea to be stuck on "looking up kotlin script definition..." background task @GenericNerdyUsername can you take a look please? (as alternative, I'd just rollback the sdk) |
|
Does this still happen on the main branch, without jcef? Can you diff the logs with/without jcef and show me the result? |
1c11d8d to
3db5620
Compare
3db5620 to
7db1833
Compare
|
Does this close #150579 as well? |
I can view markdown files in clion with this |
I fixed this in my overlay, forgot to push changes here |
7db1833 to
4c5a2e4
Compare
|
Should be working now |
niknetniko
left a comment
There was a problem hiding this comment.
Tested with both Intellij and Clion, both work. Very nice work!
|
@GenericNerdyUsername sorry for the late response, for some reason I didn't received a notification on my mail. FYI: could be related to https://youtrack.jetbrains.com/issue/IDEA-304608/Background-tasks-get-stuck-with-custom-Boot-Java-Runtime : build is 222 and jbr is (my guess) 223 Result of about section4c5a2e44561f4991d568d7bb7dc68d56a73a5d6c: And unstable: |
|
@ifropc what happens if you use the latest IntelliJ? |
|
@GenericNerdyUsername Do you mean from unstable? It works just fine |
|
I mean using this jdk with intellij 2022.3.1 |
|
It will probably work, but version in master is 222, so if PR is merged as is, it will break things for somebody else too (potentially) |
fb4f921 to
d2231fc
Compare
|
@ifropc do things work now? |
|
@GenericNerdyUsername yes, everything is working now, thank you very much for your patience! |
|
Can confirm PyCharm Professional builds and runs fine with this, including the web stuff. I'm inclined to merge this unless someone objects. |
|
I've just fixed Gitlab Merge Request plugin with it - thanks!:) |
|
Can you please fix the merge conflict? |
d2231fc to
b1efcf7
Compare
|
Done |
|
Fantastic work, all! Is anyone working on porting this to 22.11? |
|
Cherry picking this commit on top of the diff --git a/pkgs/development/compilers/jetbrains-jdk/default.nix b/pkgs/development/compilers/jetbrains-jdk/default.nix
index 3d1e8a30434..ebeb218c1b5 100644
--- a/pkgs/development/compilers/jetbrains-jdk/default.nix
+++ b/pkgs/development/compilers/jetbrains-jdk/default.nix
@@ -29,8 +29,8 @@
openjdk17.overrideAttrs (oldAttrs: rec {
pname = "jetbrains-jdk-jcef";
- javaVersion = "17.0.5";
- build = "653.14";
+ javaVersion = "17.0.3";
+ build = "653";
# To get the new tag:
# git clone https://github.com/jetbrains/jetbrainsruntime
# cd jetbrainsruntime
@@ -88,7 +88,7 @@ openjdk17.overrideAttrs (oldAttrs: rec {
runHook preInstall
rm -rf build/linux-x86_64-server-${buildType}/images/jdk
- mv build/linux-x86_64-server-${buildType}/images/jbrsdk${jcefSuffix}-${javaVersion}-linux-x64${debugSuffix}-b${build} build/linux-x86_64-server-${buildType}/images/jdk
+ mv build/linux-x86_64-server-${buildType}/images/jbrsdk${jcefSuffix}-${javaVersion}-x64${debugSuffix}-b${build} build/linux-x86_64-server-${buildType}/images/jdk
'' + oldAttrs.installPhase + "runHook postInstall";
postInstall = ''All that should be needed is testing and making a pr, but I'm too tired to do that rn. Would you be ok with doing that @l0b0? |

Description of changes
Update the jetbrains jdk, but also add JCEF support, allowing the markdown plugin in jetbrains IDEs to work correctly.
Closes #160468 and #143122. Also updates the IDEs.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes