Skip to content

virtualbox: 6.1.36 -> 6.1.40#196570

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
vcunat:p/virtualbox-fix
Oct 20, 2022
Merged

virtualbox: 6.1.36 -> 6.1.40#196570
vcunat merged 1 commit intoNixOS:staging-nextfrom
vcunat:p/virtualbox-fix

Conversation

@vcunat
Copy link
Member

@vcunat vcunat commented Oct 18, 2022

In particular this fixes build of linuxPackages*.virtualbox after updating linuxHeaders to 6.0

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member Author

vcunat commented Oct 18, 2022

The error before fixing: https://hydra.nixos.org/build/195699374

@vcunat vcunat requested a review from svanderburg October 18, 2022 10:40
@vcunat vcunat mentioned this pull request Oct 18, 2022
Merged
13 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Oct 18, 2022
@trofi
Copy link
Contributor

trofi commented Oct 19, 2022

Could it be it requires more hashes to fix?

error: hash mismatch in fixed-output derivation '/nix/store/9wpb73xiav7yzbrvalr0jlsipkl9f62n-Oracle_VM_VirtualBox_Extension_Pack-6.1.40.vbox-extpack.drv':
         specified: sha256-PITwF3pHoZaa/3yY4B3c7t1QNI9WzFLWP0wt04rSynU=
            got:    sha256-Kc+EEOJRTqQ5P2P16VW4MReHhzZ5/COumol/tw7z+Eo=
error: hash mismatch in fixed-output derivation '/nix/store/229dajd43ny4270ssqxfj3862gvvqh2i-VBoxGuestAdditions_6.1.40.iso.drv':
         specified: sha256-yYfNyMCMV59W2SHIUmmu6sP69ja6vQHZRhzleck2LN0=
            got:    sha256-1FbFWZJvGo/dclkFbgpQ8SM5/UlBIs8w23c24gMpcMY=

@vcunat
Copy link
Member Author

vcunat commented Oct 19, 2022

Oh right, I didn't notice the comment above the line I changed.

@vcunat vcunat marked this pull request as draft October 19, 2022 09:13
@vcunat
virtualbox: 6.1.36 -> 6.1.40
1511e46 
In particular this fixes build of linuxPackages*.virtualbox after
updating linuxHeaders to 6.0
@vcunat
Copy link
Member Author

vcunat commented Oct 19, 2022

OK, I followed the instructions now – except there's version 7 as well and I wanted to keep conservative on a package that I don't know. And I built locally anything with "virtualbox" that I found in all-packages.nix and linuxPackages.

@vcunat vcunat marked this pull request as ready for review October 19, 2022 09:34
@ofborg ofborg bot requested a review from cdepillabout October 19, 2022 09:39
@trofi
Copy link
Contributor

trofi commented Oct 19, 2022

Result of nixpkgs-review pr 196570 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • linuxKernel.packages.hardkernel_4_14.virtualbox
  • linuxKernel.packages.hardkernel_4_14.virtualboxGuestAdditions
  • linuxPackages_hardkernel_latest.virtualbox
  • linuxPackages_hardkernel_latest.virtualboxGuestAdditions
49 packages built:
  • linuxKernel.packages.linux_4_14.virtualbox
  • linuxKernel.packages.linux_4_14.virtualboxGuestAdditions
  • linuxPackages_4_14_hardened.virtualbox (linuxKernel.packages.linux_4_14_hardened.virtualbox)
  • linuxPackages_4_14_hardened.virtualboxGuestAdditions (linuxKernel.packages.linux_4_14_hardened.virtualboxGuestAdditions)
  • linuxKernel.packages.linux_4_19.virtualbox
  • linuxKernel.packages.linux_4_19.virtualboxGuestAdditions
  • linuxPackages_4_19_hardened.virtualbox (linuxKernel.packages.linux_4_19_hardened.virtualbox)
  • linuxPackages_4_19_hardened.virtualboxGuestAdditions (linuxKernel.packages.linux_4_19_hardened.virtualboxGuestAdditions)
  • linuxKernel.packages.linux_4_9.virtualbox
  • linuxKernel.packages.linux_4_9.virtualboxGuestAdditions
  • linuxKernel.packages.linux_5_10.virtualbox
  • linuxKernel.packages.linux_5_10.virtualboxGuestAdditions
  • linuxPackages_5_10_hardened.virtualbox (linuxKernel.packages.linux_5_10_hardened.virtualbox)
  • linuxPackages_5_10_hardened.virtualboxGuestAdditions (linuxKernel.packages.linux_5_10_hardened.virtualboxGuestAdditions)
  • linuxPackages.virtualbox (linuxKernel.packages.linux_5_15.virtualbox)
  • linuxPackages.virtualboxGuestAdditions (linuxKernel.packages.linux_5_15.virtualboxGuestAdditions)
  • linuxPackages_hardened.virtualbox (linuxPackages_5_15_hardened.virtualbox)
  • linuxPackages_hardened.virtualboxGuestAdditions (linuxPackages_5_15_hardened.virtualboxGuestAdditions)
  • linuxKernel.packages.linux_5_19.virtualbox
  • linuxKernel.packages.linux_5_19.virtualboxGuestAdditions
  • linuxKernel.packages.linux_5_19_hardened.virtualbox
  • linuxKernel.packages.linux_5_19_hardened.virtualboxGuestAdditions
  • linuxKernel.packages.linux_5_4.virtualbox
  • linuxKernel.packages.linux_5_4.virtualboxGuestAdditions
  • linuxPackages_latest.virtualbox (linuxKernel.packages.linux_6_0.virtualbox)
  • linuxPackages_latest.virtualboxGuestAdditions (linuxKernel.packages.linux_6_0.virtualboxGuestAdditions)
  • linuxPackages_latest-libre.virtualbox (linuxKernel.packages.linux_latest_libre.virtualbox)
  • linuxPackages_latest-libre.virtualboxGuestAdditions (linuxKernel.packages.linux_latest_libre.virtualboxGuestAdditions)
  • linuxPackages-libre.virtualbox (linuxKernel.packages.linux_libre.virtualbox)
  • linuxPackages-libre.virtualboxGuestAdditions (linuxKernel.packages.linux_libre.virtualboxGuestAdditions)
  • linuxPackages_lqx.virtualbox (linuxKernel.packages.linux_lqx.virtualbox)
  • linuxPackages_lqx.virtualboxGuestAdditions (linuxKernel.packages.linux_lqx.virtualboxGuestAdditions)
  • linuxPackages_testing_bcachefs.virtualbox (linuxKernel.packages.linux_testing_bcachefs.virtualbox)
  • linuxPackages_testing_bcachefs.virtualboxGuestAdditions (linuxKernel.packages.linux_testing_bcachefs.virtualboxGuestAdditions)
  • linuxPackages_xanmod.virtualbox (linuxKernel.packages.linux_xanmod.virtualbox)
  • linuxPackages_xanmod.virtualboxGuestAdditions (linuxKernel.packages.linux_xanmod.virtualboxGuestAdditions)
  • linuxPackages_xanmod_latest.virtualbox (linuxKernel.packages.linux_xanmod_latest.virtualbox)
  • linuxPackages_xanmod_latest.virtualboxGuestAdditions (linuxKernel.packages.linux_xanmod_latest.virtualboxGuestAdditions)
  • linuxPackages_xanmod_stable.virtualbox (linuxKernel.packages.linux_xanmod_stable.virtualbox)
  • linuxPackages_xanmod_stable.virtualboxGuestAdditions (linuxKernel.packages.linux_xanmod_stable.virtualboxGuestAdditions)
  • linuxPackages_xanmod_tt.virtualbox (linuxKernel.packages.linux_xanmod_tt.virtualbox)
  • linuxPackages_xanmod_tt.virtualboxGuestAdditions (linuxKernel.packages.linux_xanmod_tt.virtualboxGuestAdditions)
  • linuxPackages_zen.virtualbox (linuxKernel.packages.linux_zen.virtualbox)
  • linuxPackages_zen.virtualboxGuestAdditions (linuxKernel.packages.linux_zen.virtualboxGuestAdditions)
  • virtualbox
  • virtualboxExtpack
  • virtualboxHardened
  • virtualboxHeadless
  • virtualboxWithExtpack

@vcunat vcunat merged commit 0eb4236 into NixOS:staging-next Oct 20, 2022
@vcunat
Copy link
Member Author

vcunat commented Oct 20, 2022

Let me merge early so that we progress. This isn't getting to master immediately anyway.

@vcunat vcunat deleted the p/virtualbox-fix branch October 20, 2022 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svanderburg svanderburg Awaiting requested review from svanderburg

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vcunat @trofi