Skip to content

allAliases: init#196419

Draft
roberth wants to merge 1 commit intoNixOS:masterfrom
hercules-ci:pkgs-allAliases
Draft

allAliases: init#196419
roberth wants to merge 1 commit intoNixOS:masterfrom
hercules-ci:pkgs-allAliases

Conversation

@roberth
Copy link
Member

@roberth roberth commented Oct 17, 2022

Description of changes

Presumably needed by node2nix. Part of a long term solution to such problems as #192859

Allow generic dependency injection code to avoid aliases, e.g.

getPkg = name:
  if ! pkgs?allAliases.${name}
  then pkgs.${name}
  else ...
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Allow generic dependency injection code to avoid aliases, e.g.

    getPkg = name:
      if ! pkgs?allAliases.${name}
      then pkgs.${name}
      else ...
@roberth roberth mentioned this pull request Oct 17, 2022
13 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 17, 2022
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants