Merged
Conversation
ofborg
bot
added
8.has: package (new)
roberth
force-pushed
the
restore-aliases
branch
from
06737ed to
4a3778b
Compare
This reverts commit ba33195. Removing aliases without warning is not ok, because it breaks a lot of third party code, without a grace period during which the ecosystem can adapt.
This reverts commit ddb7c7b. Removing aliases without warning is not ok, because it breaks a lot of third party code, without a grace period during which the ecosystem can adapt.
This reverts commit d062073. Removing aliases without warning is not ok, because it breaks a lot of third party code, without a grace period during which the ecosystem can adapt.
roberth
force-pushed
the
restore-aliases
branch
from
4a3778b to
e72450d
Compare
This was referenced Oct 15, 2022
Member
Author
|
We're 18 hours and 1 rebase in. I'd like to merge this soon. |
infinisil
approved these changes
Oct 15, 2022
mweinelt
added a commit
to NixOS/release-wiki
that referenced
this pull request
Mar 6, 2023
It is controversial, given the downstream breakage and the lack of a grace-period. The last time I tried this, the changes were reverted. Cf. NixOS/nixpkgs#196001
mweinelt
added a commit
to NixOS/release-wiki
that referenced
this pull request
Mar 6, 2023
It is controversial, given the downstream breakage and the lack of a grace-period. The last time I tried this, the changes were reverted. Cf. NixOS/nixpkgs#196001
mweinelt
added a commit
to NixOS/release-wiki
that referenced
this pull request
Mar 6, 2023
It is controversial, given the downstream breakage and the lack of a grace-period. The last time I tried this, the changes were reverted. Cf. NixOS/nixpkgs#196001
12 tasks
12 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Reverts #192681, #192870
Does not break #192859
Resolves #195702
Removing aliases without warning is not ok, because it breaks a lot of third party code, without a grace period during which the ecosystem can adapt.
We must throw warnings first. If that's not possible, we have to make that possible first.
Please consider that when these errors occur in a third party repo*, many users will not be able to fix the problem.
*: e.g. home-manager, various flakes, etc, as opposed to nixpkgs (2nd party) or user/team/project config (1st party)
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes