Skip to content

sigtool: 0.1.2 → 0.1.3#194994

Closed
rrbutani wants to merge 1 commit intoNixOS:stagingfrom
rrbutani:feature/sigtool-0.1.3
Closed

sigtool: 0.1.2 → 0.1.3#194994
rrbutani wants to merge 1 commit intoNixOS:stagingfrom
rrbutani:feature/sigtool-0.1.3

Conversation

@rrbutani
Copy link
Contributor

@rrbutani rrbutani commented Oct 7, 2022

Description of changes

Updated sigtool to 0.1.3.

0.1.3 just adds support for the --sign flag (an alias); I came across this as part of #194634 (comment).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@rrbutani rrbutani mentioned this pull request Oct 7, 2022
92 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 7, 2022
@lovesegfault
Copy link
Member

This has to target the staging branch due to the mass rebuilds.

@SuperSandro2000
Copy link
Member

This PR rebuilds a lot of packages which means we must target staging. Please follow the contributing guide to not potentially ping a lot of people.

@rrbutani rrbutani changed the base branch from master to staging October 8, 2022 16:13
@rrbutani
Copy link
Contributor Author

rrbutani commented Oct 8, 2022

🤦 I'm sorry; I rebased on top of staging and pushed before changing the base branch here

Should I just open a new PR?

@flokli
Copy link
Member

flokli commented Oct 8, 2022

Yes please.

@flokli flokli closed this Oct 8, 2022
@NixOS NixOS locked as resolved and limited conversation to collaborators Oct 8, 2022
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Oct 8, 2022
@rrbutani rrbutani deleted the feature/sigtool-0.1.3 branch October 8, 2022 20:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants