Skip to content

python3Packages.spectral-cube: fix dependencies#194642

Merged
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
smaret:fix-spectral-cube-deps
Oct 11, 2022
Merged

python3Packages.spectral-cube: fix dependencies#194642
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
smaret:fix-spectral-cube-deps

Conversation

@smaret
Copy link
Member

@smaret smaret commented Oct 5, 2022

Description of changes

Fix python3Packages.spectral-cube dependencies.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Oct 5, 2022
@smaret
Copy link
Member Author

smaret commented Oct 5, 2022

Result of nixpkgs-review pr 194642 run on x86_64-darwin 1

8 packages built:
  • python310Packages.aplpy
  • python310Packages.pyregion
  • python310Packages.reproject
  • python310Packages.spectral-cube
  • python39Packages.aplpy
  • python39Packages.pyregion
  • python39Packages.reproject
  • python39Packages.spectral-cube

@smaret smaret marked this pull request as ready for review October 5, 2022 20:39
@smaret smaret requested review from FRidh and jonringer as code owners October 5, 2022 20:40
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 5, 2022
@smaret smaret force-pushed the fix-spectral-cube-deps branch from b836adf to acc3247 Compare October 8, 2022 11:41
@smaret
Copy link
Member Author

smaret commented Oct 8, 2022

Result of nixpkgs-review pr 194642 run on x86_64-darwin 1

8 packages built:
  • python310Packages.aplpy
  • python310Packages.pyregion
  • python310Packages.reproject
  • python310Packages.spectral-cube
  • python39Packages.aplpy
  • python39Packages.pyregion
  • python39Packages.reproject
  • python39Packages.spectral-cube

@smaret smaret requested a review from SuperSandro2000 October 8, 2022 21:06
@SuperSandro2000
Copy link
Member

@ofborg build python310Packages.reproject python310Packages.spectral-cube

@SuperSandro2000
Copy link
Member

I think now dask is failing

=================================== FAILURES ===================================
____________ test_repartition_npartitions[<lambda>1-float-5-1-True] ____________
[gw37] linux -- Python 3.10.7 /nix/store/bnqsrgcx271flnlhnb9pxps4nyjrydk4-python3-3.10.7/bin/python3.10
use_index = True, n = 1, k = 5, dtype = <class 'float'>
transform = <function <lambda> at 0xfffe6066f760>
    @pytest.mark.parametrize("use_index", [True, False])
    @pytest.mark.parametrize("n", [1, 2, 4, 5])
    @pytest.mark.parametrize("k", [1, 2, 4, 5])
    @pytest.mark.parametrize("dtype", [float, "M8[ns]"])
    @pytest.mark.parametrize("transform", [lambda df: df, lambda df: df.x])
    def test_repartition_npartitions(use_index, n, k, dtype, transform):
        df = pd.DataFrame(
            {"x": [1, 2, 3, 4, 5, 6] * 10, "y": list("abdabd") * 10},
            index=pd.Series([10, 20, 30, 40, 50, 60] * 10, dtype=dtype),
        )
        df = transform(df)
        a = dd.from_pandas(df, npartitions=n, sort=use_index)
        b = a.repartition(k)
        assert_eq(a, b)
        assert b.npartitions == k
        parts = dask.get(b.dask, b.__dask_keys__())
>       assert all(map(len, parts))
E       assert False
E        +  where False = all(<map object at 0xfffe406cb8e0>)
E        +    where <map object at 0xfffe406cb8e0> = map(len, (10.0    1\n10.0    1\n10.0    1\n10.0    1\n10.0    1\n10.0    1\n10.0    1\n10.0    1\n10.0    1\n10.0    1\nName: x, dtype: i...0    6\n60.0    6\n60.0    6\n60.0    6\n60.0    6\n60.0    6\n60.0    6\n60.0    6\n60.0    6\n60.0    6\nName: x, dtype: int64))
dask/dataframe/tests/test_dataframe.py:2153: AssertionError
____________ test_repartition_npartitions[<lambda>0-float-5-1-True] ____________
[gw66] linux -- Python 3.10.7 /nix/store/bnqsrgcx271flnlhnb9pxps4nyjrydk4-python3-3.10.7/bin/python3.10
use_index = True, n = 1, k = 5, dtype = <class 'float'>
transform = <function <lambda> at 0xfffec252c700>
    @pytest.mark.parametrize("use_index", [True, False])
    @pytest.mark.parametrize("n", [1, 2, 4, 5])
    @pytest.mark.parametrize("k", [1, 2, 4, 5])
    @pytest.mark.parametrize("dtype", [float, "M8[ns]"])
    @pytest.mark.parametrize("transform", [lambda df: df, lambda df: df.x])
    def test_repartition_npartitions(use_index, n, k, dtype, transform):
        df = pd.DataFrame(
            {"x": [1, 2, 3, 4, 5, 6] * 10, "y": list("abdabd") * 10},
            index=pd.Series([10, 20, 30, 40, 50, 60] * 10, dtype=dtype),
        )
        df = transform(df)
        a = dd.from_pandas(df, npartitions=n, sort=use_index)
        b = a.repartition(k)
        assert_eq(a, b)
        assert b.npartitions == k
        parts = dask.get(b.dask, b.__dask_keys__())
>       assert all(map(len, parts))
E       assert False
E        +  where False = all(<map object at 0xfffec1265a50>)
E        +    where <map object at 0xfffec1265a50> = map(len, (      x  y\n10.0  1  a\n10.0  1  a\n10.0  1  a\n10.0  1  a\n10.0  1  a\n10.0  1  a\n10.0  1  a\n10.0  1  a\n10.0  1  a\n10.0  1....0  5  b\n60.0  6  d\n60.0  6  d\n60.0  6  d\n60.0  6  d\n60.0  6  d\n60.0  6  d\n60.0  6  d\n60.0  6  d\n60.0  6  d\n60.0  6  d))
dask/dataframe/tests/test_dataframe.py:2153: AssertionError

@smaret
Copy link
Member Author

smaret commented Oct 10, 2022

Indeed, dask fails to build on arch64-linux, but this is not related to this PR.

@SuperSandro2000 SuperSandro2000 merged commit 723a0b4 into NixOS:master Oct 11, 2022
@smaret
Copy link
Member Author

smaret commented Oct 11, 2022

Thanks for the review @SuperSandro2000.

@smaret smaret deleted the fix-spectral-cube-deps branch October 11, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants