timezone service: use /etc/zoneinfo instead of tzinfo directly#19449
Merged
edolstra merged 2 commits intoNixOS:masterfrom Oct 11, 2016
Merged
timezone service: use /etc/zoneinfo instead of tzinfo directly#19449edolstra merged 2 commits intoNixOS:masterfrom
edolstra merged 2 commits intoNixOS:masterfrom
Conversation
abbradar
added
0.kind: bug
This was referenced Oct 11, 2016
Member
|
Note that this prevents services from being restarted automatically when |
Member
Author
|
Oh, indeed. Well, for services I guess that's okay to depend on |
…irectly This is needed so systemd can extract timezone from a symlink.
This is needed because now /etc/localtime symlink points there.
Member
Author
|
I've updated this to instead only link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Partially fixes #19339. Also probably fixes some other uses of timezones in systemd. Needs NixOS/systemd#7 to fully fix the bug, but can be merged separately.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Tested in a VM with NixOS/systemd#7 applied to systemd.
timedatectlnow works properly.