Skip to content

canokey-qemu: init at unstable-2022-06-23 and add QEMU support#194254

Merged
lovesegfault merged 2 commits intoNixOS:masterfrom
oxalica:pkg/canokey-qemu
Oct 4, 2022
Merged

canokey-qemu: init at unstable-2022-06-23 and add QEMU support#194254
lovesegfault merged 2 commits intoNixOS:masterfrom
oxalica:pkg/canokey-qemu

Conversation

@oxalica
Copy link
Contributor

@oxalica oxalica commented Oct 3, 2022

Description of changes

This PR introduced an option canokeySupport to enable simulation for CanoKey via -device canokey. It enables testing GPG Card, U2F, FIDO2 and etc in QEMU VM. Since it pulls in a 3rd-party package dependency, it's disabled by default.
Refs:

  1. CanoKey, an open-source secure key. https://www.canokeys.org/
  2. QEMU docs for CanoKey support. https://qemu.readthedocs.io/en/latest/system/devices/canokey.html

Manually tested with qemu.override { canokeySupport = true; hostCpuOnly = true; }.

I'm currently put it under pkgs/applications/virtualization/qemu since it's for QEMU only. Not sure if there's a better place for it.


Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • canokey-qemu
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@oxalica oxalica requested a review from alyssais October 3, 2022 17:03
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 3, 2022
@lovesegfault lovesegfault merged commit 6b58d8b into NixOS:master Oct 4, 2022
@oxalica oxalica deleted the pkg/canokey-qemu branch October 4, 2022 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants