canokey-qemu: init at unstable-2022-06-23 and add QEMU support#194254
Merged
lovesegfault merged 2 commits intoNixOS:masterfrom Oct 4, 2022
Merged
canokey-qemu: init at unstable-2022-06-23 and add QEMU support#194254lovesegfault merged 2 commits intoNixOS:masterfrom
lovesegfault merged 2 commits intoNixOS:masterfrom
Conversation
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR introduced an option
canokeySupportto enable simulation for CanoKey via-device canokey. It enables testing GPG Card, U2F, FIDO2 and etc in QEMU VM. Since it pulls in a 3rd-party package dependency, it's disabled by default.Refs:
Manually tested with
qemu.override { canokeySupport = true; hostCpuOnly = true; }.I'm currently put it under
pkgs/applications/virtualization/qemusince it's for QEMU only. Not sure if there's a better place for it.Result of
nixpkgs-reviewrun on x86_64-linux 11 package built:
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes