Skip to content

electrum: make compatible with protobuf 4+#194112

Merged
prusnak merged 1 commit intoNixOS:masterfrom
prusnak:electrum
Oct 4, 2022
Merged

electrum: make compatible with protobuf 4+#194112
prusnak merged 1 commit intoNixOS:masterfrom
prusnak:electrum

Conversation

@prusnak
Copy link
Member

@prusnak prusnak commented Oct 2, 2022 •
edited
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@prusnak prusnak mentioned this pull request Oct 2, 2022
Closed
@ofborg ofborg bot requested review from joachifm and np October 2, 2022 18:49
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 2, 2022
@austinbutler
Copy link
Member

austinbutler commented Oct 4, 2022

Result of nixpkgs-review pr 194112 run on x86_64-linux 1

1 package built:
  • electrum

@bobby285271 bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 4, 2022
@prusnak prusnak merged commit 01c6a05 into NixOS:master Oct 4, 2022
@prusnak prusnak deleted the electrum branch October 4, 2022 08:20
@oxalica
Copy link
Contributor

oxalica commented Oct 7, 2022

Doesn't is just hide the existing issue? It's intentional to mark as not supporting protobuf 4. spesmilo/electrum#7922

@prusnak
Copy link
Member Author

prusnak commented Oct 8, 2022

Doesn't is just hide the existing issue? It's intentional to mark as not supporting protobuf 4. spesmilo/electrum#7922

Not really. Upstream wants to keep old pb2.py file to support older protobuf. We regenerate the pb2.py file to new version, because we don't care about older protobuf.

@oxalica oxalica mentioned this pull request Oct 8, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joachifm joachifm Awaiting requested review from joachifm

@np np Awaiting requested review from np

1 more reviewer

@austinbutler austinbutler austinbutler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

electrum: fails to build on x86_64

4 participants

@prusnak @austinbutler @oxalica @bobby285271