nodejs: add back newer bypass-xcrun patch#193759
Merged
happysalada merged 2 commits intoNixOS:stagingfrom Sep 30, 2022
Merged
Conversation
13 tasks
13 tasks
This was referenced Jun 23, 2023
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
See discussion in #193533
This was a Node.js patch we'd been carrying for a while but it got dropped/forgotten with the v16 update. With
nodePackagesnow being on Node.js v18, some packages fail because bundlednode-gypis looking for Xcode and this patch was intended to fake version data to prevent thatI made a new patch file instead of reusing the Node.js v14 patch file since between v14 and v16 because the xcode_emulation.py file was refactored
I tested this with
bitwarden-cliin GitHub Actions to see if it resolves the need for xcbuild innodePackages, since I don't actually have a Mac. It seemed to work there and I assume it will work for other similarly affected packages as wellThis is my first staging PR so let me know if I need to do anything else for it. Thanks!
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes