Python: use separate output for tkinter by FRidh · Pull Request #19309 · NixOS/nixpkgs

FRidh · 2016-10-06T19:11:38Z

Motivation for this change

See issue #19255 and #1819.

Unify expressions of different interpreters
Reduce closure size of Python 3.x interpreters

Things done

Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)
- NixOS
- OS X
- Linux
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

mention-bot · 2016-10-06T19:11:48Z

@FRidh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @chaoflow and @domenkozar to be potential reviewers.

FRidh · 2016-10-10T08:02:17Z

Sigh... putting curses in a separate output won't help because python and libpython directly link against it.

domenkozar · 2016-10-10T18:33:23Z

@FRidh that's fine I think. It's not ideal, but this way Python will be way less painful on Nix.

FRidh · 2016-10-13T19:58:20Z

@vcunat yes they should. I thought I got them all.

FRidh · 2016-10-13T20:00:56Z

ahh yes, it wasn't just pythonPackages.modules.sqlite3 but also pythonPackages.sqlite3. I forgot those.

FRidh · 2016-10-13T20:02:30Z

I'm sure I've asked this before but how can one test whether the whole of Nixpkgs evaluates?

vcunat · 2016-10-13T20:04:57Z

There are also python27Full and curses, maybe more.

vcunat · 2016-10-13T20:06:38Z

@FRidh: for quick eval I regularly use

nix-env -f . -qaP --meta --json --drv-path --show-trace >/dev/null

But one can do nix-build pkgs/top-level/release.nix -A tarball -Q to be proper (all Hydra platforms etc.).

FRidh · 2016-10-13T20:12:28Z

Thanks @vcunat . That should be it (efb6052)

vcunat · 2016-10-13T22:11:44Z

No, there were quite a few more: 6eeea6e.

FRidh · 2016-10-14T06:32:48Z

hmm, it seemed to evaluate. But thank you for fixing the (hopefully) last ones.

domenkozar · 2016-10-14T09:04:29Z

Thank you @FRidh for doing this ❤️

copumpkin · 2016-10-16T02:19:42Z

Argh, a complication: the darwin stdenv bootstrap depends on python (because LLVM's build process uses it) and this change massively slowed down our bootstrap process, since it now needs to build a ton of TK stuff, multiple times since we have multiple pythons to kill dependencies on the bootstrap tools 😦

Can we make the TK stuff optional so I can ask for a TK-free python during bootstrap? Then only the final "userspace" one would get TK.

copumpkin · 2016-10-16T02:25:18Z

Also, it actually seems to have broken the python build, which prevents bootstrap 😢

vcunat · 2016-10-16T08:00:04Z

@copumpkin: I think that should be solved by using pythonSmall for anything needed during bootstrapping, as that one is without X, tcl and tk. EDIT: we should probably switch all those packages to it regardless of platform.

FRidh · 2016-10-16T10:18:09Z

I am actually thinking of getting rid of the tkinter output again, and just
build without tkinter by default, and then build once with tkinter and copy
the tkinter module in another derivation. Then we can get rid of
pythonSmall.

On Oct 16, 2016 10:00 AM, "Vladimír Čunát" [email protected] wrote:

@copumpkin https://github.com/copumpkin: I think that should be solved
by using pythonSmall for bootstrapping, as that one is without X, tcl and
tk.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#19309 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACB872EUsaiKFngXWl_w_-ylPl14we98ks5q0dmJgaJpZM4KQTvy
.

FRidh · 2016-10-16T12:30:39Z

@vcunat @copumpkin see #19594 , I think it's a better solution than what I merged earlier.

In NixOS#19309 a separate output for tkinter was added. Several dependencies of Python depend indirectly on Python. We have the following two paths: ``` ‘python-2.7.12’ - ‘tk-8.6.6’ - ‘libXft-2.3.2’ - ‘libXrender-0.9.10’ - ‘libX11-1.6.4’ - ‘libxcb-1.12’ - ‘libxslt-1.1.29’- ‘libxml2-2.9.4’ - ‘python-2.7.12’ ‘python-2.7.12’ - ‘tk-8.6.6’ - ‘libXft-2.3.2’ - ‘fontconfig-2.12.1’ - ‘dejavu-fonts-2.37’ - ‘fontforge-20160404’ - ‘python-2.7.12’ ``` Because only `tkinter` needs this, I added ``` pythonSmall = python.override {x11Support = false;}; ``` to break the infinite recursion. We also still have the output `tkinter`. However, we might as well build without x11Support by default. Then we build with x11Support as well so we get the tkinter module and put that in a separate package.

copumpkin · 2016-10-16T15:55:13Z

Dammit, I was just reaching for pythonSmall during bootstrap 😄 I don't really have a strong opinion on how Python actually works but I'll take a look at the other PR and opine if I have something useful to say.

nixos-discourse · 2021-01-09T10:51:08Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/python3x-vs-python3xfull-package-name-change-in-2016-vs-standardized-semantic-adopt-to-standard-python-semantic/10896/1

nixos-discourse · 2021-08-13T13:05:59Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/help-setting-up-nix-shell-with-python-and-vulkan/14512/2

FRidh added 6.topic: python Python is a high-level, general-purpose programming language. 1.severity: mass-rebuild labels Oct 6, 2016

FRidh changed the title ~~Outputs~~ Python: use separate output for tkinter Oct 6, 2016

FRidh added the 2.status: work-in-progress label Oct 7, 2016

FRidh force-pushed the outputs branch 4 times, most recently from d728388 to 5d41890 Compare October 10, 2016 07:49

FRidh removed the 2.status: work-in-progress label Oct 10, 2016

FRidh force-pushed the outputs branch from ab4eb87 to ba4221a Compare October 10, 2016 07:58

FRidh added the 2.status: work-in-progress label Oct 10, 2016

FRidh force-pushed the outputs branch 2 times, most recently from 4d3fc5a to 1c72375 Compare October 10, 2016 08:10

FRidh removed the 2.status: work-in-progress label Oct 10, 2016

FRidh force-pushed the outputs branch from 1c72375 to e7e278c Compare October 10, 2016 08:27

FRidh changed the base branch from master to staging October 10, 2016 08:28

FRidh added 7 commits October 10, 2016 10:33

Python 2.7: separate output for tkinter

bee4392

Python 3.3: separate output for tkinter

cf0932e

Python 3.4: separate output for tkinter

0bd4b31

Python 3.5: separate output for tkinter

0a08fcd

Python 3.6: separate output for tkinter

a2720a2

Python: remove modules and pythonFull

104c50d

Python: update docs separate output tkinter

d3766b2

FRidh force-pushed the outputs branch from e7e278c to d3766b2 Compare October 10, 2016 08:33

FRidh changed the base branch from staging to master October 10, 2016 08:34

This was referenced Oct 10, 2016

pysaml depends on pythonFull? #19225

Closed

The pythonFull vs. python distinction causes (me) a lot of pain #19255

Closed

domenkozar mentioned this pull request Oct 14, 2016

Python ecosystem improvements (placeholder issue) #1819

Open

37 tasks

FRidh mentioned this pull request Oct 14, 2016

nixpkgs python repl isn't very terminal-friendly #17607

Closed

This was referenced Oct 14, 2016

Migrate to Python 3 as default install #18185

Closed

Python 3 dependency bloat #12333

Closed

FRidh mentioned this pull request Oct 16, 2016

Python: no separate output for tkinter but build interpreter twice #19594

Merged

7 tasks

FRidh deleted the outputs branch July 31, 2017 19:02

flokli mentioned this pull request Aug 17, 2019

python3Minimal: Add top-level for a minimal Python 3 build #66762

Merged

10 tasks

alecandido mentioned this pull request Mar 24, 2025

Python: Matplotlib & Tkinter cachix/devenv#1792

Closed

Uh oh!

Conversation

FRidh commented Oct 6, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation for this change

Things done

Uh oh!

mention-bot commented Oct 6, 2016

Uh oh!

FRidh commented Oct 10, 2016

Uh oh!

domenkozar commented Oct 10, 2016

Uh oh!

FRidh commented Oct 13, 2016

Uh oh!

FRidh commented Oct 13, 2016

Uh oh!

FRidh commented Oct 13, 2016

Uh oh!

vcunat commented Oct 13, 2016

Uh oh!

vcunat commented Oct 13, 2016

Uh oh!

FRidh commented Oct 13, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vcunat commented Oct 13, 2016

Uh oh!

FRidh commented Oct 14, 2016

Uh oh!

domenkozar commented Oct 14, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

copumpkin commented Oct 16, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

copumpkin commented Oct 16, 2016

Uh oh!

vcunat commented Oct 16, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FRidh commented Oct 16, 2016

Uh oh!

FRidh commented Oct 16, 2016

Uh oh!

copumpkin commented Oct 16, 2016

Uh oh!

nixos-discourse commented Jan 9, 2021

Uh oh!

nixos-discourse commented Aug 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

FRidh commented Oct 6, 2016 •

edited

Loading

FRidh commented Oct 13, 2016 •

edited

Loading

domenkozar commented Oct 14, 2016 •

edited

Loading

copumpkin commented Oct 16, 2016 •

edited

Loading

vcunat commented Oct 16, 2016 •

edited

Loading