Skip to content

utillinux: drop alias, don't throw#192870

Merged
mweinelt merged 1 commit intoNixOS:masterfrom
mweinelt:drop-utillinux-throw
Sep 25, 2022
Merged

utillinux: drop alias, don't throw#192870
mweinelt merged 1 commit intoNixOS:masterfrom
mweinelt:drop-utillinux-throw

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Sep 25, 2022 •
edited
Loading

It confuses node2nix, which looks for utillinux in pkgs but does not expect a throw.

# Workaround to cope with utillinux in Nixpkgs 20.09 and util-linux in Nixpkgs master
utillinux = if pkgs ? utillinux then pkgs.utillinux else pkgs.util-linux;

Closes: #192859

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@mweinelt
utillinux: drop alias, don't throw
ba33195 
It confuses node2nix, which looks for utillinux in pkgs but does not
expect a throw.
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Sep 25, 2022
@mweinelt mweinelt merged commit 766cb44 into NixOS:master Sep 25, 2022
@mweinelt mweinelt deleted the drop-utillinux-throw branch September 25, 2022 10:58
@mweinelt
Copy link
Member Author

mweinelt commented Sep 25, 2022

Result of nixpkgs-review pr 192870 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • dat
  • vimPlugins.coc-imselect
5 packages failed to build:
  • ldgallery
  • navidrome
  • odoo
  • oni2
  • spacegun
228 packages built:
  • airfield
  • antennas
  • antora
  • balanceofsatoshis
  • base16-builder
  • bat-extras.prettybat
  • bitwarden-cli
  • botamusique
  • breitbandmessung
  • castnow
  • cinnamon.xreader
  • code-server
  • commitlint
  • concurrently
  • create-cycle-app
  • cz-cli
  • deltachat-desktop
  • discourse
  • discourseAllPlugins
  • elmPackages.create-elm-app
  • elmPackages.elm-analyse
  • elmPackages.elm-coverage
  • elmPackages.elm-doc-preview
  • elmPackages.elm-git-install
  • elmPackages.elm-language-server
  • elmPackages.elm-live
  • elmPackages.elm-optimize-level-2
  • elmPackages.elm-pages
  • elmPackages.elm-review
  • elmPackages.elm-test
  • elmPackages.elm-upgrade
  • elmPackages.elm-verify-examples
  • elmPackages.elm-xref
  • emojione
  • epgstation
  • ethercalc
  • fast-cli
  • flexoptix-app
  • flood
  • fx_cast_bridge
  • gnomeExtensions.pop-shell
  • google-clasp
  • grafana-image-renderer
  • gtop
  • haste-server
  • hueadm
  • image_optim
  • imapnotify
  • imgbrd-grabber
  • iosevka
  • iosevka-comfy.comfy
  • iosevka-comfy.comfy-duo
  • iosevka-comfy.comfy-fixed
  • iosevka-comfy.comfy-motion
  • iosevka-comfy.comfy-motion-duo
  • iosevka-comfy.comfy-motion-fixed
  • iosevka-comfy.comfy-wide
  • iosevka-comfy.comfy-wide-duo
  • iosevka-comfy.comfy-wide-fixed
  • isso
  • jellyfin
  • jellyfin-media-player
  • jellyfin-web
  • joplin
  • lessc
  • mastodon-bot
  • matrix-appservice-irc
  • matrix-appservice-slack
  • mjolnir
  • mongosh
  • morgen
  • mx-puppet-discord
  • n8n
  • netlify-cli
  • newman
  • node2nix
  • onlykey
  • open-stage-control
  • openmoji-black
  • openmoji-color
  • pm2
  • polaris
  • polaris-web
  • postcss-cli
  • pscid
  • psitransfer
  • pulp
  • purescript-psa
  • pyright
  • python310Packages.batchspawner
  • python310Packages.dockerspawner
  • python310Packages.jupyterhub
  • python310Packages.jupyterhub-ldapauthenticator
  • python310Packages.jupyterhub-systemdspawner
  • python310Packages.jupyterhub-tmpauthenticator
  • python310Packages.oauthenticator
  • python39Packages.batchspawner
  • python39Packages.dockerspawner
  • python39Packages.jupyterhub
  • python39Packages.jupyterhub-ldapauthenticator
  • python39Packages.jupyterhub-systemdspawner
  • python39Packages.jupyterhub-tmpauthenticator
  • python39Packages.oauthenticator
  • redoc-cli
  • reveal-md
  • sage
  • sageWithDoc
  • shepherd
  • shout
  • slack
  • sloc
  • styx
  • teams
  • teck-programmer
  • theLoungePlugins.plugins.closepms
  • theLoungePlugins.plugins.giphy
  • theLoungePlugins.plugins.shortcuts
  • theLoungePlugins.themes.abyss
  • theLoungePlugins.themes.amoled
  • theLoungePlugins.themes.amoled-sourcecodepro
  • theLoungePlugins.themes.bdefault
  • theLoungePlugins.themes.bmorning
  • theLoungePlugins.themes.chord
  • theLoungePlugins.themes.classic
  • theLoungePlugins.themes.common
  • theLoungePlugins.themes.crypto
  • theLoungePlugins.themes.discordapp
  • theLoungePlugins.themes.dracula
  • theLoungePlugins.themes.dracula-official
  • theLoungePlugins.themes.flat-blue
  • theLoungePlugins.themes.flat-dark
  • theLoungePlugins.themes.gruvbox
  • theLoungePlugins.themes.hexified
  • theLoungePlugins.themes.ion
  • theLoungePlugins.themes.light
  • theLoungePlugins.themes.midnight
  • theLoungePlugins.themes.mininapse
  • theLoungePlugins.themes.monokai-console
  • theLoungePlugins.themes.mortified
  • theLoungePlugins.themes.neuron-fork
  • theLoungePlugins.themes.new-morning
  • theLoungePlugins.themes.new-morning-compact
  • theLoungePlugins.themes.nologo
  • theLoungePlugins.themes.nord
  • theLoungePlugins.themes.onedark
  • theLoungePlugins.themes.purplenight
  • theLoungePlugins.themes.scoutlink
  • theLoungePlugins.themes.seraphimrp
  • theLoungePlugins.themes.solarized
  • theLoungePlugins.themes.solarized-fork-monospace
  • theLoungePlugins.themes.zenburn
  • theLoungePlugins.themes.zenburn-monospace
  • theLoungePlugins.themes.zenburn-sourcecodepro
  • thelounge
  • triton
  • uppy-companion
  • vimPlugins.YouCompleteMe
  • vimPlugins.coc-clangd
  • vimPlugins.coc-cmake
  • vimPlugins.coc-css
  • vimPlugins.coc-diagnostic
  • vimPlugins.coc-docker
  • vimPlugins.coc-emmet
  • vimPlugins.coc-eslint
  • vimPlugins.coc-explorer
  • vimPlugins.coc-flutter
  • vimPlugins.coc-git
  • vimPlugins.coc-go
  • vimPlugins.coc-haxe
  • vimPlugins.coc-highlight
  • vimPlugins.coc-html
  • vimPlugins.coc-java
  • vimPlugins.coc-jest
  • vimPlugins.coc-json
  • vimPlugins.coc-lists
  • vimPlugins.coc-markdownlint
  • vimPlugins.coc-metals
  • vimPlugins.coc-nginx
  • vimPlugins.coc-pairs
  • vimPlugins.coc-prettier
  • vimPlugins.coc-pyright
  • vimPlugins.coc-python
  • vimPlugins.coc-r-lsp
  • vimPlugins.coc-rls
  • vimPlugins.coc-rust-analyzer
  • vimPlugins.coc-sh
  • vimPlugins.coc-smartf
  • vimPlugins.coc-snippets
  • vimPlugins.coc-solargraph
  • vimPlugins.coc-sqlfluff
  • vimPlugins.coc-stylelint
  • vimPlugins.coc-sumneko-lua
  • vimPlugins.coc-tabnine
  • vimPlugins.coc-texlab
  • vimPlugins.coc-toml
  • vimPlugins.coc-tslint
  • vimPlugins.coc-tslint-plugin
  • vimPlugins.coc-tsserver
  • vimPlugins.coc-ultisnips
  • vimPlugins.coc-vetur
  • vimPlugins.coc-vimlsp
  • vimPlugins.coc-vimtex
  • vimPlugins.coc-wxml
  • vimPlugins.coc-yaml
  • vimPlugins.coc-yank
  • vimPlugins.markdown-preview-nvim
  • vscode
  • vscode-extensions.matklad.rust-analyzer
  • vscode-extensions.ms-python.vscode-pylance
  • vscode-extensions.vadimcn.vscode-lldb
  • vscode-fhs
  • vscode-with-extensions
  • vscodium
  • vscodium-fhs
  • wasm-strip
  • wasm-text-gen
  • wast-refmt
  • webassemblyjs-cli
  • webassemblyjs-repl
  • weylus
  • whalebird
  • whitebophir
  • wrangler
  • wring
  • yaml-language-server
  • ycmd
  • zigbee2mqtt
  • zx

klDen pushed a commit to klDen/nixos-conf that referenced this pull request Sep 25, 2022
readd slack: NixOS/nixpkgs#192870
40b500f
@asymmetric
Copy link
Contributor

asymmetric commented Oct 2, 2022

OK but this removes all mentions of a rename? I've just been bitten by this

@mweinelt
Copy link
Member Author

mweinelt commented Oct 2, 2022

Yeah, not sure what a good solution here is.

@asymmetric
Copy link
Contributor

asymmetric commented Oct 5, 2022

Maybe we just mention it in the release notes?

@infinisil
Copy link
Member

infinisil commented Oct 12, 2022

This is not okay! With #192681 and this PR you're removing an attribute in a single release that didn't even give a warning beforehand!

This PR needs to be reverted, and tbh #192681 needs to be changed too. Deprecation first needs a warning before it can become an error.

@infinisil infinisil mentioned this pull request Oct 12, 2022
Closed
@roberth roberth mentioned this pull request Oct 14, 2022
Merged
13 tasks
@roberth
Copy link
Member

roberth commented Oct 15, 2022

I propose to fix the problem by reverting the removals and throws: #196001

This is not okay!

If we don't provide a window during which things don't break, we're inevitably causing a lot of pain, especially when 3rd party projects are involved. I explain it in a bit more detail in the PR.

@roberth
Copy link
Member

roberth commented Oct 15, 2022

If node2nix has to ignore aliases, it may retrieve a set of deprecated attributes as follows:

lib.mapAttrs (_: _: null) (import ./pkgs/top-level/aliases.nix lib pkgs pkgs)

We should expose this attrset in Nixpkgs itself, but third party repos may want to polyfill that with an expression like the above.

@roberth
Copy link
Member

roberth commented Oct 17, 2022

We should expose this attrset in Nixpkgs itself,

#196419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

slack: 'utillinux' has been renamed to/replaced by 'util-linux'

4 participants

@mweinelt @asymmetric @infinisil @roberth