Skip to content

humility: init at unstable-2022-09-15#192842

Merged
AndersonTorres merged 2 commits intoNixOS:masterfrom
therishidesai:humility
Sep 25, 2022
Merged

humility: init at unstable-2022-09-15#192842
AndersonTorres merged 2 commits intoNixOS:masterfrom
therishidesai:humility

Conversation

@therishidesai
Copy link
Contributor

@therishidesai therishidesai commented Sep 25, 2022

Description of changes

Added the humility debugger for the hubris OS.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 25, 2022
danielfullmer
danielfullmer suggested changes Sep 25, 2022
View reviewed changes
Copy link
Contributor

@danielfullmer danielfullmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you've automatically reformatted all-packages.nix, which is making this PR huge. Try to make just the change needed for this PR without the automatic reformatting.

@therishidesai therishidesai changed the title added humility package humility: 0.0.1-nightly Sep 25, 2022
@therishidesai therishidesai changed the title humility: 0.0.1-nightly humility: init at 0.0.1-nightly Sep 25, 2022
@therishidesai therishidesai force-pushed the humility branch 2 times, most recently from 436e70b to dae4fe2 Compare September 25, 2022 00:48
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Sep 25, 2022
AndersonTorres
AndersonTorres suggested changes Sep 25, 2022
View reviewed changes
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome aboard! :)

@therishidesai therishidesai changed the title humility: init at 0.0.1-nightly humility: init at unstable-09-15-2022 Sep 25, 2022
@therishidesai therishidesai requested review from AndersonTorres and danielfullmer and removed request for AndersonTorres and danielfullmer September 25, 2022 02:22
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 25, 2022
AndersonTorres
AndersonTorres suggested changes Sep 25, 2022
View reviewed changes
@therishidesai therishidesai requested review from AndersonTorres and danielfullmer and removed request for AndersonTorres and danielfullmer September 25, 2022 07:07
@AndersonTorres AndersonTorres changed the title humility: init at unstable-09-15-2022 humility: init at unstable-2022-09-15 Sep 25, 2022
@AndersonTorres AndersonTorres merged commit bc2035b into NixOS:master Sep 25, 2022
@alyssais
Copy link
Member

alyssais commented Oct 30, 2022

This doesn't eval with aliases disabled. Did OfBorg pass?

@alyssais alyssais mentioned this pull request Oct 30, 2022
Closed
13 tasks
@therishidesai
Copy link
Contributor Author

therishidesai commented Oct 31, 2022

Yeah It looks like OfBorg passed

@tjni tjni mentioned this pull request Nov 6, 2022
Merged
13 tasks
SuperSandro2000 added a commit that referenced this pull request Nov 10, 2022
@SuperSandro2000
Merge pull request #199794 from tjni/fix-humility-hash
717ccac 
fixes #192842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

1 more reviewer

@danielfullmer danielfullmer danielfullmer requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@therishidesai @alyssais @danielfullmer @AndersonTorres