Skip to content

lz4: fix static build#191915

Merged
superherointj merged 1 commit intoNixOS:stagingfrom
robx:lz4-static
Sep 19, 2022
Merged

lz4: fix static build#191915
superherointj merged 1 commit intoNixOS:stagingfrom
robx:lz4-static

Conversation

@robx
Copy link
Contributor

@robx robx commented Sep 19, 2022

Description of changes

This patches lz4 with lz4/lz4#1162, fixing the static build.

Before this, I see

$ nix build nixpkgs#pkgsStatic.lz4
error: builder for '/nix/store/4ssbvpxh8bp5gdk7517ip22myl6b39an-lz4-static-x86_64-unknown-linux-musl-1.9.4.drv' failed with exit code 2;
       last 10 log lines:
       > build flags: -j2 -l2 SHELL=/nix/store/p7bpdnxqd3i5hwm92mrscf7mvxk66404-bash-5.1-p16/bin/bash PREFIX=\$\(out\) INCLUDEDIR=\$\(dev\)/include BUILD_STATIC=yes BUILD_SHARED=no WINDRES:=x86_64-unknown-linux-musl-windres
       > make[1]: Entering directory '/build/source/lib'
       > compiling static library
       > compiling dynamic library 1.9.4
       > /nix/store/q8zpwwa77zaa5h0p15iiid26g5ak6s7l-x86_64-unknown-linux-musl-binutils-2.38/bin/x86_64-unknown-linux-musl-ld: /nix/store/ravnd17fg4maxzc5ns8vbijn7ah3p4b1-x86_64-unknown-linux-musl-stage-final-gcc-11.3.0/lib/gcc/x86_64-unknown-linux-musl/11.3.0/crtbeginT.o: relocation R_X86_64_32 against hidden symbol `__TMC_END__' can not be used when making a shared object
       > /nix/store/q8zpwwa77zaa5h0p15iiid26g5ak6s7l-x86_64-unknown-linux-musl-binutils-2.38/bin/x86_64-unknown-linux-musl-ld: failed to set dynamic section sizes: bad value
       > collect2: error: ld returned 1 exit status
       > make[1]: *** [Makefile:122: liblz4.so.1.9.4] Error 1
       > make[1]: Leaving directory '/build/source/lib'
       > make: *** [Makefile:57: lib-release] Error 2
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@robx robx mentioned this pull request Sep 19, 2022
Closed
@bobby285271 bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 19, 2022
@robx
Copy link
Contributor Author

robx commented Sep 19, 2022

(that CI error seems due to a full disk, error: creating directory '/nix/store/add-3770538-0/x/pkgs/applications/version-management/gitea': No space left on device)

@superherointj
Copy link
Contributor

superherointj commented Sep 19, 2022

Shouldn't this PR be targeting staging?

@robx
Copy link
Contributor Author

robx commented Sep 19, 2022

Shouldn't this PR be targeting staging?

I don't know. Happy to update if it should.

@superherointj
Copy link
Contributor

superherointj commented Sep 19, 2022

I don't know. Happy to update if it should.

It causes downstream upgrade of 18463 packages.

@robx robx mentioned this pull request Sep 19, 2022
Closed
@robx
Copy link
Contributor Author

robx commented Sep 19, 2022

I don't know. Happy to update if it should.

It causes downstream upgrade of 18463 packages.

I guess that's a yes? So I'll rebase this on top of staging, and change the PR base to staging?

@superherointj
Copy link
Contributor

superherointj commented Sep 19, 2022

I guess that's a yes? So I'll rebase this on top of staging, and change the PR base to staging?

Yes.

@robx robx changed the base branch from master to staging September 19, 2022 19:34
superherointj
superherointj approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@superherointj superherointj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can build lz4 from this PR. I have not tested downstream breakage because it is just too large.

@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package labels Sep 19, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Sep 19, 2022
@superherointj superherointj merged commit 9dbb17c into NixOS:staging Sep 19, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. and removed 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. labels Sep 19, 2022
@robx robx deleted the lz4-static branch September 19, 2022 20:50
@mweinelt mweinelt mentioned this pull request Oct 4, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

@kalbasit kalbasit Awaiting requested review from kalbasit

@Mic92 Mic92 Awaiting requested review from Mic92

@zowoq zowoq Awaiting requested review from zowoq

@jonringer jonringer Awaiting requested review from jonringer

@teto teto Awaiting requested review from teto

@ttuegel ttuegel Awaiting requested review from ttuegel

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@marsam marsam Awaiting requested review from marsam

@FRidh FRidh Awaiting requested review from FRidh

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

+1 more reviewer

@superherointj superherointj superherointj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@robx @superherointj @SuperSandro2000 @bobby285271