Skip to content

clang-unwrapped: mv {$out,$python}/share/scan-view/*.py#191801

Merged
7c6f434c merged 1 commit intoNixOS:stagingfrom
ShamrockLee:clang-python-scan-view
Jul 18, 2023
Merged

clang-unwrapped: mv {$out,$python}/share/scan-view/*.py#191801
7c6f434c merged 1 commit intoNixOS:stagingfrom
ShamrockLee:clang-python-scan-view

Conversation

@ShamrockLee
Copy link
Contributor

@ShamrockLee ShamrockLee commented Sep 18, 2022 •
edited
Loading

Description of changes

This fixes "${clang-unwrapped.python}/bin/scan-view" by providing the relative dependency
"${clang-unwrapped.python}/share/scan-view/ScanView.py"

Cc: @lovek323 @7c6f434c @dtzWill @primeos

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage (Done evaluation.)
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ShamrockLee ShamrockLee mentioned this pull request Sep 18, 2022
Merged
13 tasks
@ShamrockLee
Copy link
Contributor Author

ShamrockLee commented Sep 18, 2022 •
edited
Loading

OfBorg complains during ofborg-eval-lib-test

tar: nss-3.83/nss/tests: Cannot mkdir: No space left on device

Update:
Now it errors out in a different place during the second run (without modifying the expression).

    got new GC root '/build/nix-test/tests/gc-non-blocking/store/pgmlwswllaww81k7bdca7g5fx68fnjin-non-blocking'
    reading GC root from client: error: writing to file: Broken pipe
    1 store paths deleted, 0.00 MiB freed
    error: reading from file: Connection reset by peer
    + rm /build/nix-test/tests/gc-non-blocking/running
    + outPath=
    ++ onError
    ++ set +x
    gc-non-blocking.sh: test failed at:
      main in gc-non-blocking.sh:27

Maybe it's just because of too much loading?

nixpkgs-review does evaluation and

nix-build --arg pkgs "import ./. {}" ./lib/tests/release.nix

builds on my x86_64-linux machine.

@ShamrockLee
Copy link
Contributor Author

ShamrockLee commented Sep 20, 2022

@ofborg eval

@ShamrockLee ShamrockLee marked this pull request as ready for review September 20, 2022 08:43
@ShamrockLee ShamrockLee force-pushed the clang-python-scan-view branch from c581564 to 7bb7970 Compare November 7, 2022 23:01
@ShamrockLee
clang-unwrapped: mv {$out,$python}/share/scan-view/*.py
93b5ec0 
This fixes "${clang-unwrapped.python}/bin/scan-view"
by providing the relative dependency
"${clang-unwrapped.python}/share/scan-view/ScanView.py"
@ShamrockLee ShamrockLee force-pushed the clang-python-scan-view branch from 7bb7970 to 93b5ec0 Compare November 7, 2022 23:05
@ofborg ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. label Nov 7, 2022
@ofborg ofborg bot requested review from 7c6f434c, dtzWill, lovek323 and primeos November 7, 2022 23:15
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Nov 7, 2022
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label May 21, 2023
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jul 18, 2023

bump

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 18, 2023
@7c6f434c 7c6f434c merged commit 1e8f4ab into NixOS:staging Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@lovek323 lovek323 Awaiting requested review from lovek323

@primeos primeos Awaiting requested review from primeos

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShamrockLee @SuperSandro2000 @7c6f434c