Skip to content

lldb: Add Lua support#190908

Merged
7c6f434c merged 2 commits intoNixOS:masterfrom
a12l:lldb-lua
Oct 5, 2022
Merged

lldb: Add Lua support#190908
7c6f434c merged 2 commits intoNixOS:masterfrom
a12l:lldb-lua

Conversation

@a12l
Copy link
Contributor

@a12l a12l commented Sep 12, 2022

Description of changes

Add lua5_3 as a build input to enable LLDB's Lua language bindings.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@a12l a12l requested a review from matthewbauer as a code owner September 12, 2022 10:28
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 12, 2022
@a12l
Copy link
Contributor Author

a12l commented Sep 12, 2022

@matthewbauer, @7c6f434c, @dtzWill, @primeos, @lovek323: Should the changes be made to specific major versions, or to the files in the git directory (a little unsure how you've structured up LLVM packaging)?

@winterqt
Copy link
Member

winterqt commented Sep 22, 2022

I believe you have to add this to all LLVM version folders that you want this change to affect, though I'm not sure if this should be retroactively added to all of them (maybe just the default + latest)?

@a12l
Copy link
Contributor Author

a12l commented Sep 22, 2022

(maybe just the default + latest)

The changed version (14) is the default and the latest (if you don't count the git version).

@SuperSandro2000
Copy link
Member

This change should be added to all lldb versions that support this feature.

@primeos
Copy link
Member

primeos commented Sep 22, 2022

LLVM changes should always be applied to the git version as well (unless the changes only target old LLVM versions) - otherwise those changes will be missing in future LLVM versions as we package new major releases based on the current state of the git version.

Apart from that changes are usually applied to all LLVM versions that supported (as @SuperSandro2000 already stated). That seems best practice but I think that it would also be acceptable (but likely less desirable) to only target the latest stable release and git version.

@a12l
Copy link
Contributor Author

a12l commented Sep 26, 2022

Commit introducing the Lua bindings, from what I can gather from LLVM's VCS, was merged into 14, so the changes should only be applied to 14 (as already done) and git.

[1] https://reviews.llvm.org/rG67f94e5a9745665dd62550c75cb16569fbb0059d

@7c6f434c 7c6f434c merged commit 1723d25 into NixOS:master Oct 5, 2022
@rrbutani rrbutani mentioned this pull request Oct 10, 2022
92 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants