Skip to content

libbfd: add CC_FOR_BUILD into depends#190897

Merged
trofi merged 1 commit intoNixOS:stagingfrom
trofi:libbfd-cross
Sep 12, 2022
Merged

libbfd: add CC_FOR_BUILD into depends#190897
trofi merged 1 commit intoNixOS:stagingfrom
trofi:libbfd-cross

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Sep 12, 2022 •
edited
Loading

Without the change cross-compiling libbfd fails as:

  GEN      doc/bfdver.texi
  CCLD     doc/chew.stamp
...-bash-5.1-p16/bin/bash: line 1: gcc: command not found

Tested on pkgsCross.riscv64.libbfd.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@trofi
libbfd: add CC_FOR_BUILD into depends
58c0dec 
Without the change cross-compiling libbfd fails as:

      GEN      doc/bfdver.texi
      CCLD     doc/chew.stamp
    ...-bash-5.1-p16/bin/bash: line 1: gcc: command not found

Tested on `pkgsCross.riscv64.libbfd`.
@trofi trofi requested a review from alyssais September 12, 2022 08:44
@trofi trofi mentioned this pull request Sep 12, 2022
Merged
13 tasks
alyssais
alyssais approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You beat me to making exactly the same change. :)

@ofborg ofborg bot requested a review from Ericson2314 September 12, 2022 09:20
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Sep 12, 2022
@trofi trofi merged commit bfc0175 into NixOS:staging Sep 12, 2022
@trofi trofi deleted the libbfd-cross branch September 12, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alyssais alyssais alyssais approved these changes

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trofi @alyssais