Skip to content

nixos/vector: fix validation for cross compiling#190215

Merged
happysalada merged 1 commit intoNixOS:masterfrom
SuperSandro2000:vector
Sep 9, 2022
Merged

nixos/vector: fix validation for cross compiling#190215
happysalada merged 1 commit intoNixOS:masterfrom
SuperSandro2000:vector

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Sep 8, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 8, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 8, 2022
@SuperSandro2000 SuperSandro2000 mentioned this pull request Sep 9, 2022
Merged
13 tasks
@happysalada
Copy link
Contributor

happysalada commented Sep 9, 2022

Thank you!

@happysalada happysalada merged commit 08dd3b9 into NixOS:master Sep 9, 2022
@SuperSandro2000 SuperSandro2000 deleted the vector branch September 10, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@happysalada happysalada Awaiting requested review from happysalada

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SuperSandro2000 @happysalada