Merged
Conversation
ofborg
bot
added
8.has: package (new)
Contributor
|
This is good stuff! And you were even bold enough to keep in the update.sh in the oil language. |
Contributor
|
For my understanding, the last time I looked into this, the blocker was that the Solana development tools download binaries for the BPF SDK at runtime, did you manage to build that from source? I don’t see a reference to it in the diff. |
Janik-Haag
added
the
12.first-time contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solana was added in pull #121009 along with a few other updates like #169506 (added an
update.shscript) and #152055 (fixed a few dependencies).The current solana package only provides the
clibinary. This package adds the following binariessolanasolana-bench-tpssolana-faucetsolana-gossipsolana-installsolana-keygensolana-ledger-toolsolana-log-analyzersolana-net-shapersolana-sys-tunersolana-validatorcargo-build-bpfcargo-test-bpfsolana-dossolana-install-initsolana-stake-accountssolana-test-validatorsolana-tokenssolana-watchtowerThese packages are helpful if you would like to begin developing solana programs, operating a validator, RPC node, or contributing to the solana codebase.
Currently there is already a solana testnet cli package from @ruuda and @happysalada. Given that the solana codebase is large and there are many associated binaries I created a separate
solana-validatorpackage. I am very curious to receive feedback if this package should be separated or combined with the prior.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes