dmd: disable whitespace-sensitive tests for binutils-2.39#189087
Merged
trofi merged 1 commit intoNixOS:masterfrom Sep 2, 2022
Merged
dmd: disable whitespace-sensitive tests for binutils-2.39#189087trofi merged 1 commit intoNixOS:masterfrom
trofi merged 1 commit intoNixOS:masterfrom
Conversation
ofborg
bot
added
10.rebuild-darwin: 1-10
Contributor
Author
|
/cc @ThomasMader @dukc |
Without the change two tests fail on `binutils-2.39` due to whitespace
change in `objdump` output as:
FAILED targets:
- runnable/cdvecfill.sh
- compilable/cdcmp.d
Let's disable the tests until they are fixed upstream:
https://issues.dlang.org/show_bug.cgi?id=23317
trofi
force-pushed
the
dmd-fix-for-binutils-2.39
branch
from
21bb71b to
ca4361d
Compare
lionello
approved these changes
Sep 1, 2022
bobby285271
added
12.approvals: 1
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the change two tests fail on
binutils-2.39due to whitespacechange in
objdumpoutput as:Let's disable the tests until they are fixed upstream:
https://issues.dlang.org/show_bug.cgi?id=23317
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes