Skip to content

kcov: pin to binutils-2.38 until upstream ports to 2.39#188259

Merged
lovesegfault merged 1 commit intoNixOS:masterfrom
trofi:kcov-fix-for-binutils-2.39
Aug 25, 2022
Merged

kcov: pin to binutils-2.38 until upstream ports to 2.39#188259
lovesegfault merged 1 commit intoNixOS:masterfrom
trofi:kcov-fix-for-binutils-2.39

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Aug 25, 2022

Without the change build fails on binutils-2.39 branch as:

/build/source/src/parsers/bfd-disassembler.cc: In constructor 'BfdDisassembler::BfdDisassembler()':
/build/source/src/parsers/bfd-disassembler.cc:78:38: error: too few arguments to function 'void init_disassemble_info(disassemble_info*, void*, fprintf_ftype, fprintf_styled_ftype)'
   78 |                 init_disassemble_info(&m_info, (void *)this, BfdDisassembler::opcodesFprintFuncStatic);
      |                 ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Without the change build fails on binutils-2.39 branch as:

    /build/source/src/parsers/bfd-disassembler.cc: In constructor 'BfdDisassembler::BfdDisassembler()':
    /build/source/src/parsers/bfd-disassembler.cc:78:38: error: too few arguments to function 'void init_disassemble_info(disassemble_info*, void*, fprintf_ftype, fprintf_styled_ftype)'
       78 |                 init_disassemble_info(&m_info, (void *)this, BfdDisassembler::opcodesFprintFuncStatic);
          |                 ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@trofi trofi mentioned this pull request Aug 25, 2022
13 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 25, 2022
@lovesegfault lovesegfault merged commit 17a29b3 into NixOS:master Aug 25, 2022
@trofi trofi deleted the kcov-fix-for-binutils-2.39 branch August 25, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants