Create binutils 2.38 holdback set of releases#187972
Merged
trofi merged 2 commits intoNixOS:masterfrom Aug 24, 2022
Merged
Conversation
Having all 3 of binutils, libbfd, libopcodes in one directory eases copying of the whole directory when we need to hold back old version of the whole of binutils or of it's pieces.
ofborg
bot
added
10.rebuild-darwin: 1-10
Contributor
Author
|
Example use case is build failure: Example fix: --- a/pkgs/os-specific/linux/bpftools/default.nix
+++ b/pkgs/os-specific/linux/bpftools/default.nix
@@ -1,5 +1,5 @@
{ lib, stdenv
-, libopcodes, libbfd, elfutils, readline
+, libopcodes_2_38, libbfd_2_38, elfutils, readline
, linuxPackages_latest, zlib
, python3, bison, flex
}:
@@ -9,7 +9,7 @@ stdenv.mkDerivation {
inherit (linuxPackages_latest.kernel) version src;
nativeBuildInputs = [ python3 bison flex ];
- buildInputs = [ libopcodes libbfd elfutils zlib readline ];
+ buildInputs = [ libopcodes_2_38 libbfd_2_38 elfutils zlib readline ];
preConfigure = ''
patchShebangs scripts/bpf_doc.py |
trofi
force-pushed
the
binutils-2.38-holdback
branch
from
6406e9c to
a622084
Compare
Contributor
Author
|
Needs headers fixes |
2.39 has an API breakage that will take users some time to migrate. Create _2_38 versions to allow them to hand on an old version for a while.
trofi
force-pushed
the
binutils-2.38-holdback
branch
from
a622084 to
7fe41f9
Compare
Contributor
Author
|
Tested this change on Ready for review. |
lovesegfault
approved these changes
Aug 23, 2022
Member
lovesegfault
left a comment
lovesegfault
left a comment
There was a problem hiding this comment.
LGTM, thanks for all the work trofi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
binutils-2.39will be a disruptive release: #185297.It changes disassembly API and broke
perffor all old linux releases. We will need to holdback old release until all dependencies are ported to 2.39.
This change introduces held back release of
libbfdandlibopcodes. It's a copy of currentbinutilsrelease.The plan is to pin all to-be-broken packages to this 2.38 release.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes