Skip to content

nixos/tests/ec2: pass -F backing image format as it is now necessary#187855

Closed
RaitoBezarius wants to merge 1 commit intoNixOS:masterfrom
RaitoBezarius:cleanup-ec2-tests
Closed

nixos/tests/ec2: pass -F backing image format as it is now necessary#187855
RaitoBezarius wants to merge 1 commit intoNixOS:masterfrom
RaitoBezarius:cleanup-ec2-tests

Conversation

@RaitoBezarius
Copy link
Member

@RaitoBezarius RaitoBezarius commented Aug 22, 2022

Description of changes

This performs a cleanup necessary since a certain version of QEMU (7 maybe?) as qemu-img requires the backing image file format now to be passed.
It seems like some EC2-based tests are broken BTW, due to conflicting definitions on serial port.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@RaitoBezarius RaitoBezarius requested a review from fgaz August 22, 2022 11:43
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Aug 22, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 22, 2022
@RaitoBezarius RaitoBezarius mentioned this pull request Aug 22, 2022
Open
@RaitoBezarius
Copy link
Member Author

RaitoBezarius commented Aug 24, 2022

According to git blame, ping @nlewo @tfc for openstack-image.nix (which seems to fail), @fgaz for image-contents.nix (which seems to be stuck too but succeed?), @tfc @rnhmjoj @thefloweringash for ec2.nix (which seems to fail due to amazon-init) if I'm not wrong.

@fgaz
Copy link
Member

fgaz commented Aug 24, 2022

image-contents.nix (which seems to be stuck too but succeed?)

what do you mean?

@RaitoBezarius
Copy link
Member Author

RaitoBezarius commented Aug 24, 2022

image-contents.nix (which seems to be stuck too but succeed?)

what do you mean?

nix-build image-contents.nix does not terminate on my machine, I don't know if this is expected or not.

@fgaz
Copy link
Member

fgaz commented Aug 24, 2022

Let's see if ofborg succeeds

@GrahamcOfBorg build nixosTests.image-contents

@fgaz
Copy link
Member

fgaz commented Aug 24, 2022

Huh, this is bad... https://hydra.nixos.org/job/nixos/release-22.05/nixos.tests.image-contents.x86_64-linux
I wish hydra notified me of the failure.

@RaitoBezarius
Copy link
Member Author

RaitoBezarius commented Aug 24, 2022

Huh, this is bad... https://hydra.nixos.org/job/nixos/release-22.05/nixos.tests.image-contents.x86_64-linux I wish hydra notified me of the failure.

Sorry for that, I don't know how Hydra works, maybe we can page a Hydra connoisseur to understand whether this is expected?

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Aug 25, 2022

@tfc @rnhmjoj @thefloweringash for ec2.nix (which seems to fail due to amazon-init)

Ah, right: I fixed this test once but I have (and want) nothing to do with amazon, sorry.

@RaitoBezarius
Copy link
Member Author

RaitoBezarius commented Dec 2, 2022 •
edited
Loading

As there seems to be no maintainer for EC2 or OpenStack image tests, I am in favor of removing those tests. cc @mweinelt @dasJ

@fgaz Can we proceed with the fix for image-contents?

@RaitoBezarius RaitoBezarius mentioned this pull request Dec 5, 2022
Closed
20 tasks
@RaitoBezarius
Copy link
Member Author

RaitoBezarius commented Apr 16, 2023

Superseded by #226214.

@RaitoBezarius RaitoBezarius deleted the cleanup-ec2-tests branch April 16, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fgaz fgaz Awaiting requested review from fgaz

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RaitoBezarius @fgaz @rnhmjoj