Conversation
|
This should be available more widely now. 🤞 @ofborg eval |
Will need a libbfd fix as well. Will look in detail tomorrow. Switching to draft meanwhile. |
|
More failures:
Fails to build EFI images (due to UPDATE: due to |
Fails build with a failure that looks like a |
|
Bumping binutils is always a huge pain :( |
|
d9a821e to
8ca63bb
Compare
|
|
Same failure as |
|
Hrm, I don't know what the right solution is. It's unfortunate that In the meantime maybe we should |
Note that this PR is a draft. It will require a bit of porting for older kernels (or pulling in older PR you linked is already merged into |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
With
LGTM if we can figure out what to do about the |
|
Added
That way we can pin tools to it regardless of status of this PR. The changes should be a no-op as derivation of |
There was a problem hiding this comment.
Should we use sourceRoot instead?
There was a problem hiding this comment.
sourceRoot would require us knowing the extracted path (which probably isn't a good idea to rely on), and will break patches.
There was a problem hiding this comment.
I think Sandro means cd $sourceRoot
|
More failures:
|
|
Rebased against current master to include all the |
|
@vcunat Usually helps me get a jobset for these kinds of bumps |
|
Also asked to create a jobset on infra matrix channel: https://app.element.io/#/room/#infra:nixos.org/$Glu5NtSnZGrc_3TdGbA89SAslq4tJGiGVnFgiaglGHw |
|
New failures: UPDATE: it's a minor output change difference. |
|
Jobset finished with: Rebased current branch past all the fixes above. Ready for review. |
|
You're a superstar trofi :) Happy to see this land! |
|
Heh, you are too kind :) |
|
Since this merge, on macos 10.15 (and reportedly also darwin aarch64): |
This usually happens when a command is completely missing between pipes: Possibly a This update dropped one patch that is directly relevant. I thought it was upstreamed, but perhaps it does not quite work: - # Breaks nm BSD flag detection
- ./0001-Revert-libtool.m4-fix-nm-BSD-flag-detection.patchTrying to reproduce locally meanwhile. |
|
Aha, Do you know where Could it be that it's an ancient |
|
Oh, it's something called |
|
Proposed |
|
Seems to have broken cross-compilation of libbfd. |
|
Ah, because this PR enabled the libbfd documentation |
|
Let's try to sort it with #190897 |
Changes: https://sourceware.org/pipermail/binutils/2022-August/122246.html
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes