libfido2: Add openssl to propagatedBuildInputs#184510
Merged
ck3d merged 1 commit intoNixOS:stagingfrom Aug 4, 2022
Merged
Conversation
ck3d
reviewed
Aug 3, 2022
26a3d03 to
272864d
Compare
prusnak
approved these changes
Aug 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The pkgconfig requires
libcrypto. In the minimalsystemdStage1,opensslisn't pulled in by existing dependencies so the probe forlibfido2fails:So despite being enabled, FIDO2 support isn't actually built at all:
After the change:
#179823 is required for TPM2 and FIDO2 support to be actually usable, but I think we can merge this now while that PR is being discussed.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes