Closed
Conversation
|
@danbst, thanks for your PR! By analyzing the annotation information on this pull request, we identified @sfultong, @eelcovisser and @fpletz to be potential reviewers |
Contributor
|
ACK, looks good 👍 I'm surprised mention-bot mentioned me. I think I made one PR for tomcat ages ago. |
Contributor
Author
|
Removed WIP, ping @svanderburg |
See migration changelogs at - 7.0 -> 8.0: https://tomcat.apache.org/migration-8.html - 8.0 -> 8.5: https://tomcat.apache.org/migration-85.html
danbst
force-pushed
the
tomcat_cleanup
branch
from
0bcdcb2 to
a85347f
Compare
Contributor
Author
|
Bump service default to tomcat85, upstream default. Added changelogs to commit description, TLDR backwards compatible for most of users, but requires java 7 as minimal JDK |
danbst
force-pushed
the
tomcat_cleanup
branch
from
59f7e2f to
a85347f
Compare
Contributor
|
Reviewed, looks good! |
Contributor
|
+1 for merge to master and backport to release-16.09. |
Contributor
Author
|
should I squash commits? |
Contributor
|
@danbst: Nope, they look nice and clean as is :-) |
Contributor
|
Pushed to master (63f9ef9 with parents). Maybe wait a couple of days before backporting to release-16.09? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update tomcats, add more versions and remove one error in service logs.
Also, webapps folder takes ~40% of package, so I decided to move it to separate output (it isn't a hard requirement for tomcat)
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)I'm going to run all tomcats on my server and then I'll update the WIP status.