Skip to content

[DRAFT] python310Packages.afdko: 3.9.0 -> 3.9.1#182941

Closed
onny wants to merge 1 commit intoNixOS:masterfrom
onny:afdko
Closed

[DRAFT] python310Packages.afdko: 3.9.0 -> 3.9.1#182941
onny wants to merge 1 commit intoNixOS:masterfrom
onny:afdko

Conversation

@onny
Copy link
Contributor

@onny onny commented Jul 26, 2022

Description of changes

update package

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@onny onny requested review from FRidh and jonringer as code owners July 26, 2022 09:01
@onny onny marked this pull request as draft July 26, 2022 09:01
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 26, 2022
@onny
Copy link
Contributor Author

onny commented Jul 26, 2022

@sternenseemann Trying to update your python package, unfortunately the libxml2 not found error reoccurs

  -- Found LibXml2: /nix/store/c8p91c6fm67f4ldza6d811wfj61far9f-libxml2-2.9.14/lib/libxml2.so (found version "2.9.14")
  -- Could not locate LibXml2 or system is Linux, will install externally & statically link
  CMake Error at /nix/store/grd724gvgblkvklrmbdyqm5jp8phyb7r-cmake-3.23.2/share/cmake-3.23/Modules/ExternalProject.cmake:2540 (message):
    error: could not find git for clone of external.libxml2
  Call Stack (most recent call first):
    /nix/store/grd724gvgblkvklrmbdyqm5jp8phyb7r-cmake-3.23.2/share/cmake-3.23/Modules/ExternalProject.cmake:3640 (_ep_add_download_command)
    cmake/ExternalLibXML2.cmake:23 (ExternalProject_Add)
    CMakeLists.txt:50 (include)


  -- Configuring incomplete, errors occurred!

@ofborg ofborg bot requested a review from sternenseemann July 26, 2022 09:10
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 26, 2022
@sternenseemann
Copy link
Member

sternenseemann commented Jul 26, 2022

Yes, this is because of the following problem: adobe-type-tools/afdko#1527 (comment)

I've thus opted for upgrading to 3.9.0 and waiting for 3.9.2 or 3.10.0 (whatever comes first)…

@trofi
Copy link
Contributor

trofi commented Sep 24, 2022

Should we revert 246216e meanwhile? staging (and staging-next) is still broken by 3.9.1 update: #191333 (comment) /cc @mweinelt

@sternenseemann
Copy link
Member

sternenseemann commented Sep 24, 2022

Yes.

trofi added a commit to trofi/nixpkgs that referenced this pull request Sep 24, 2022
@trofi
Revert "python3Packages.afdko: 3.9.0 -> 3.9.1"
d748989 
This reverts commit 246216e.

3.9.1 does not compile due to patch collision:

       > applying patch /nix/store/sickncxw0s730j6gfrnlsi5ndgysi6la-libxml2-cmake-find-package.patch
       > patching file CMakeLists.txt
       > Hunk #1 FAILED at 42.

Fixing it is not trivial as upstream started bundling libxml2:
  NixOS#182941 (comment)

Let's revert the update for now.
@trofi trofi mentioned this pull request Sep 24, 2022
Merged
13 tasks
@trofi
Copy link
Contributor

trofi commented Sep 24, 2022

Proposed the revert as #192768

sternenseemann pushed a commit that referenced this pull request Sep 24, 2022
@trofi @sternenseemann
Revert "python3Packages.afdko: 3.9.0 -> 3.9.1"
eb0fa0c 
This reverts commit 246216e.

3.9.1 does not compile due to patch collision:

       > applying patch /nix/store/sickncxw0s730j6gfrnlsi5ndgysi6la-libxml2-cmake-find-package.patch
       > patching file CMakeLists.txt
       > Hunk #1 FAILED at 42.

Fixing it is not trivial as upstream started bundling libxml2:
  #182941 (comment)

Let's revert the update for now.
@onny onny closed this Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@onny @sternenseemann @trofi