Skip to content

Comments

sbcl_2_1_10, sbcl_2_1_11: fix build on arm64-darwin (-fno-common fall…#182377

Merged
trofi merged 1 commit intoNixOS:staging-nextfrom
trofi:fix-sbcl-on-aarch64-darwin
Jul 24, 2022
Merged

sbcl_2_1_10, sbcl_2_1_11: fix build on arm64-darwin (-fno-common fall…#182377
trofi merged 1 commit intoNixOS:staging-nextfrom
trofi:fix-sbcl-on-aarch64-darwin

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Jul 21, 2022 •
edited
Loading

…out)

Withut this upstream backport build on arm64-drwin fails as:

duplicate symbol '_os_vm_page_size' in:
    os-common.o
    arm64-bsd-os.o
Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@trofi
sbcl_2_1_10, sbcl_2_1_11: fix build on arm64-darwin (-fno-common fall…
2632651 
…out)

Withut this upstream backport build on arm64-drwin fails as:

    duplicate symbol '_os_vm_page_size' in:
        os-common.o
        arm64-bsd-os.o
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 21, 2022
@trofi
Copy link
Contributor Author

trofi commented Jul 21, 2022

@ofborg build sbcl sbcl_2_0_8 sbcl_2_1_1 sbcl_2_1_11 sbcl_2_1_9 sbcl_2_2_6 sbclBootstrap sbcl_2_0_9 sbcl_2_1_10 sbcl_2_1_2 sbcl_2_2_4

@ofborg ofborg bot requested a review from 7c6f434c July 21, 2022 21:18
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Jul 21, 2022
@trofi
Copy link
Contributor Author

trofi commented Jul 21, 2022

Oh, some of failures are in master already. Trying staging-next regressions only:

@ofborg build sbcl_2_1_2 sbcl_2_1_9 sbcl_2_1_10 sbcl_2_1_11

@trofi trofi mentioned this pull request Jul 21, 2022
Merged
13 tasks
@trofi trofi merged commit f315837 into NixOS:staging-next Jul 24, 2022
@trofi trofi deleted the fix-sbcl-on-aarch64-darwin branch July 24, 2022 13:48
@hraban
Copy link
Member

hraban commented Sep 25, 2022

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trofi @hraban