nlohmann_json: allow overrides by eliminating use of rec#181654
Conversation
The existing nlohmann_json expression prevents users from overriding fields (like `doCheck`) because it uses `rec` in the argument to `mkDerivation`. Let's use the shiny new pass-a-function-to-`mkDerivation` feature to do the same thing without blocking overrides.
ghost
mentioned this pull request
3 tasks
ofborg
bot
added
10.rebuild-darwin: 0
Author
|
@ofborg eval I think OfBorg's aarch64-darwin is stuck again |
winterqt
approved these changes
Jul 17, 2022
Member
|
Nice catch :) |
ghost
deleted the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The existing nlohmann_json expression prevents users from overriding fields (like
doCheck) because it usesrecin the argument tomkDerivation. Let's use the shiny new pass-a-function-to-mkDerivationfeature to do the same thing without blocking overrides.Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage