You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages
Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
Tested basic functionality of all binary files (usually in ./result/bin/)
As a part of my effort of popularizing #119942, I picked this expression. However, when I used it outside stdenv, it barfed like that:
error: value is a function while a set was expected
… while evaluating anonymous lambda
at /nix/store/dgr6iwdj4ckw5hmkppnydhplqnr4j1hv-source/pkgs/stdenv/generic/make-derivation.nix:483:3:
482| in
483| fnOrAttrs:
| ^
484| if builtins.isFunction fnOrAttrs
… from call site
at /nix/store/dgr6iwdj4ckw5hmkppnydhplqnr4j1hv-source/pkgs/development/libraries/qt-5/mkDerivation.nix:17:1:
16|
17| mkDerivation (args // args_)
| ^
… while evaluating anonymous lambda
at /nix/store/dgr6iwdj4ckw5hmkppnydhplqnr4j1hv-source/pkgs/development/libraries/qt-5/mkDerivation.nix:7:1:
6|
7| args:
| ^
8|
… from call site
at /nix/store/dgr6iwdj4ckw5hmkppnydhplqnr4j1hv-source/pkgs/applications/misc/bibletime/default.nix:20:1:
19| #stdenv.
20| mkDerivation (finalAttrs: {
| ^
21| pname = "bibletime";
… while evaluating anonymous lambda
at /nix/store/dgr6iwdj4ckw5hmkppnydhplqnr4j1hv-source/pkgs/applications/misc/bibletime/default.nix:1:1:
1| { lib
| ^
2| #, stdenv
… from call site
at /nix/store/dgr6iwdj4ckw5hmkppnydhplqnr4j1hv-source/lib/customisation.nix:69:16:
68| let
69| result = f origArgs;
| ^
70|
… while evaluating 'makeOverridable'
at /nix/store/dgr6iwdj4ckw5hmkppnydhplqnr4j1hv-source/lib/customisation.nix:67:24:
66| */
67| makeOverridable = f: origArgs:
| ^
68| let
… from call site
at /nix/store/dgr6iwdj4ckw5hmkppnydhplqnr4j1hv-source/lib/customisation.nix:168:34:
167|
168| in if missingArgs == [] then makeOverridable f allArgs else throw error;
| ^
169|
… while evaluating 'callPackageWith'
at /nix/store/dgr6iwdj4ckw5hmkppnydhplqnr4j1hv-source/lib/customisation.nix:117:35:
116| */
117| callPackageWith = autoArgs: fn: args:
| ^
118| let
… from call site
at /nix/store/dgr6iwdj4ckw5hmkppnydhplqnr4j1hv-source/pkgs/top-level/all-packages.nix:25796:15:
25795|
25796| bibletime = libsForQt5.callPackage ../applications/misc/bibletime { };
| ^
25797|
The qt package sets redefine mkDerivation without regard for the possibility of taking a function as an argument.
These mkDerivation functions could be adapted to support it, but all they do is add wrapQtAppsHook, so a simpler solution is to just use the normal mkDerivation and add wrapQtAppsHook yourself. So that's moving away from a form of inheritance (a "hierarchy" of mkDerivation functions) to composition, which is better.
Actually some packages, including this one, already explicitly list wrapQtAppsHook, so they depend on that hook twice (whatever that entails...) and could just switch to stdenv.mkDerivation, thereby removing the duplication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes