Skip to content

python3.pkgs.scipy: 1.8.0 -> 1.9.0rc2#180243

Closed
FRidh wants to merge 3 commits intoNixOS:masterfrom
FRidh:scipy-meson
Closed

python3.pkgs.scipy: 1.8.0 -> 1.9.0rc2#180243
FRidh wants to merge 3 commits intoNixOS:masterfrom
FRidh:scipy-meson

Conversation

@FRidh
Copy link
Member

@FRidh FRidh commented Jul 5, 2022 •
edited by mweinelt
Loading

Description of changes

Scipy 1.9 comes with meson as build backend.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 5, 2022
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Jul 5, 2022
SuperSandro2000
SuperSandro2000 reviewed Jul 7, 2022
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the final new lines for git

pkgs/development/python-modules/pyproject-metadata/default.nix
];

# Many broken tests, and missing test files
doCheck = false;
Copy link
Member

@SuperSandro2000 SuperSandro2000 Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta is missing

pkgs/development/python-modules/pyproject-metadata/default.nix
tomli
];

# Many broken tests, and missing test files
Copy link
Member

@SuperSandro2000 SuperSandro2000 Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about fetching from https://github.com/FFY00/python-pyproject-metadata?

pkgs/development/python-modules/meson-python/default.nix
postPatch = ''
substituteInPlace pyproject.toml --replace "'ninja'," ""
'';

Copy link
Member

@SuperSandro2000 SuperSandro2000 Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We aren't executing the tests, are we? https://github.com/FFY00/meson-python

@FRidh
Copy link
Member Author

FRidh commented Jul 8, 2022

No significant regressions with this update, so that's good to know.
https://hydra.nixos.org/eval/1770407?full=1#tabs-now-fail

@FRidh FRidh mentioned this pull request Sep 15, 2022
Merged
@SuperSandro2000 SuperSandro2000 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 15, 2022
@FRidh
Copy link
Member Author

FRidh commented Nov 3, 2022

Done in 44ae9b6.

@FRidh FRidh closed this Nov 3, 2022
@FRidh FRidh deleted the scipy-meson branch November 3, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FRidh @SuperSandro2000