Skip to content

Comments

sbcl: 2.2.4 -> 2.2.6#179949

Merged
7c6f434c merged 2 commits intoNixOS:masterfrom
marsam:update-sbcl
Jul 6, 2022
Merged

sbcl: 2.2.4 -> 2.2.6#179949
7c6f434c merged 2 commits intoNixOS:masterfrom
marsam:update-sbcl

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Jul 2, 2022

Description of changes

Also add support for sb-core-compression

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jul 2, 2022
@ofborg ofborg bot requested a review from 7c6f434c July 2, 2022 21:01
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Jul 2, 2022
@7c6f434c
Copy link
Member

7c6f434c commented Jul 3, 2022

@ofborg build lispPackages

@7c6f434c 7c6f434c mentioned this pull request Jul 3, 2022
Merged
13 tasks
@marsam
Copy link
Contributor Author

marsam commented Jul 3, 2022

I think aarch64-linux is failing because sb-simd. I'll take a look in the afternoon.

@marsam
Copy link
Contributor Author

marsam commented Jul 3, 2022 •
edited
Loading

Fixed the build on aarch64-linux. I've tested it on Darwin, so I'm not sure why it fails on ofborg.
@GrahamcOfBorg build sbcl
@GrahamcOfBorg build lispPackages

sternenseemann
sternenseemann reviewed Jul 3, 2022
View reviewed changes
pkgs/development/compilers/sbcl/common.nix

buildInputs = [texinfo];
nativeBuildInputs = [ texinfo ];
buildInputs = lib.optionals coreCompression [ zstd ];
Copy link
Member

@sternenseemann sternenseemann Jul 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle we could also support it for < 2.2.6 using zlib (although maybe not turn on by default).

@sternenseemann sternenseemann mentioned this pull request Jul 3, 2022
Closed
13 tasks
@sternenseemann
Copy link
Member

sternenseemann commented Jul 3, 2022

All of quicklispPackages builds with SBCL 2.2.6, at least without core compression enabled from my testing in #180059

@rapenne-s
Copy link
Member

rapenne-s commented Jul 5, 2022

I started nixpkgs-review on it which seems very long. However it quickly triggers two errors on linux-x86_64

error: builder for '/nix/store/9vdslflp9mbi6wxncvc9i08d7b5rn3x4-clpm-0.4.1.drv' failed with exit code 1;
       last 10 log lines:
       > 71: (SB-IMPL::TOPLEVEL-INIT)
       > 72: ((FLET SB-UNIX::BODY :IN SB-IMPL::START-LISP))
       > 73: ((FLET "WITHOUT-INTERRUPTS-BODY-3" :IN SB-IMPL::START-LISP))
       > 74: (SB-IMPL::%START-LISP)
       >
       > unhandled condition in --disable-debugger mode, quitting
       > ;
       > ; compilation unit aborted
       > ;   caught 2 fatal ERROR conditions
       > ;   caught 18 WARNING conditions
       For full logs, run 'nix log /nix/store/9vdslflp9mbi6wxncvc9i08d7b5rn3x4-clpm-0.4.1.drv'.
error: builder for '/nix/store/qlax0myn7djpm2v3zbcsfaar7airkz1n-sbcl-2.0.8.drv' failed with exit code 1;
       last 10 log lines:
       > * make[1]: Leaving directory '/build/sbcl-2.0.8/contrib/sb-cover'
       > make: Leaving directory '/build/sbcl-2.0.8/contrib'
       >
       > WARNING! Some of the contrib modules did not build successfully or pass
       > their self-tests. Failed contribs:"
       >   sb-concurrency
       >
       > real      0m26.331s
       > user 0m22.647s
       > sys  0m3.565s
       For full logs, run 'nix log /nix/store/qlax0myn7djpm2v3zbcsfaar7airkz1n-sbcl-2.0.8.drv'.

Are these failures already expected or introduced by this change?

@sternenseemann
Copy link
Member

sternenseemann commented Jul 6, 2022

@rapenne-s Can't reproduce this, I think this is just a case of the concurrency test suite being flaky on busy systems.

@7c6f434c
Copy link
Member

7c6f434c commented Jul 6, 2022

And a native build of 2.0.8 should not be substantially affected…

@7c6f434c 7c6f434c merged commit 0cd1b87 into NixOS:master Jul 6, 2022
@marsam marsam deleted the update-sbcl branch May 31, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sternenseemann sternenseemann sternenseemann approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marsam @7c6f434c @sternenseemann @rapenne-s