Skip to content

Comments

texlive.bin.xdvi: pull upstream darwin fix for -fno-common toolchains#179943

Merged
trofi merged 1 commit intoNixOS:masterfrom
trofi:fix-fno-common-for-texlive.bin.xdvi
Jul 4, 2022
Merged

texlive.bin.xdvi: pull upstream darwin fix for -fno-common toolchains#179943
trofi merged 1 commit intoNixOS:masterfrom
trofi:fix-fno-common-for-texlive.bin.xdvi

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Jul 2, 2022 •
edited
Loading

Without the change build fails on upstream llvm-11 as:

duplicate symbol '_info' in:
    libxdvi.a(font-open.o)
    libxdvi.a(print-log.o)
Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@trofi
texlive.bin.xdvi: pull upstream darwin fix for -fno-common toolchains
58e2a18 
Without the change build fails on upstream llvm-11 as:

    duplicate symbol '_info' in:
        libxdvi.a(font-open.o)
        libxdvi.a(print-log.o)
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 2, 2022
@github-actions github-actions bot added the 6.topic: TeX Issues regarding texlive and TeX in general label Jul 2, 2022
@trofi trofi mentioned this pull request Jul 2, 2022
Merged
13 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jul 2, 2022
@trofi
Copy link
Contributor Author

trofi commented Jul 4, 2022

@ofborg build texlive.bin.xdvi

@trofi trofi merged commit 3d8f0ff into NixOS:master Jul 4, 2022
@trofi trofi deleted the fix-fno-common-for-texlive.bin.xdvi branch July 4, 2022 23:11
@veprbl
Copy link
Member

veprbl commented Jul 5, 2022

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: TeX Issues regarding texlive and TeX in general 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trofi @veprbl