Skip to content

treewide: start cleaning up maintainer-list#178656

Merged
mweinelt merged 53 commits intoNixOS:masterfrom
helsinki-systems:fix/some-maintainer-handles
Jun 29, 2022
Merged

treewide: start cleaning up maintainer-list#178656
mweinelt merged 53 commits intoNixOS:masterfrom
helsinki-systems:fix/some-maintainer-handles

Conversation

@ajs124
Copy link
Member

@ajs124 ajs124 commented Jun 23, 2022

Description of changes

This does a few things:

  1. It fixes the github handles and adds a script to do so again
  2. It adds github handles and ids to some maintainers that didn't have them for whatever reason
  3. It removes a bunch of maintainers, that don't seem to have a github account and don't appear to be active anymore
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: printing Drivers, CUPS & Co. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: xfce The Xfce Desktop Environment 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 23, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 23, 2022
@ajs124 ajs124 requested a review from mweinelt June 23, 2022 18:46
ajs124 added 20 commits June 29, 2022 00:52
@ajs124
maintainers/fix-maintainers.pl: init
b22ac82
@ajs124
maintainers/maintainer-list: fix changed handles
d7b32a0
@ajs124
maintainers: add missing github details to karolchmist
cfdec3d
@ajs124
maintainers: add missing github handle for nessdoor
238ac95
@ajs124
maintainers: add missing github details to ivan-tkatchev
a4795d3
@ajs124
maintainers: add missing github handle for lux
251ef94
@ajs124
maintainers: add missing github details to vq
079ba6b
@ajs124
maintainers: add missing github details to delta
0f55ab1
@ajs124
maintainers: remove mehandes
026ffc3 
github account deleted
@ajs124
maintainers: remove volth
a071834 
github account deleted
@ajs124
maintainers: remove muflax
eec156d 
github account deleted
@ajs124
maintainers: remove petabyteboy
99466ee 
github account deleted
@ajs124
maintainers: remove bloomvdomino
92531d8 
github account deleted
@ajs124
maintainers: remove fuwa
8cb1366 
github account deleted
@ajs124
maintainers: remove danharaj
91b724c 
github account deleted
@ajs124
maintainers: remove piotr
ff2925f 
has not contributed since nixpkgs migrated to git
@ajs124
maintainers: remove elyhaka
be1aefa 
github account deleted
@ajs124
maintainers: remove metabar
3b5f125 
no github account + only commit is 78c052e
@ajs124
maintainers: remove Nate-Devv
59d8f2b 
no github account + only two commits 251a1cc and 09f366a
@ajs124
maintainers: remove dasuxullebt
9303950 
no github handle linked. github account with same name has not had activity for years
ajs124 added 11 commits June 29, 2022 00:55
@ajs124
maintainers: remove okasu
883e38a 
no github account linked
@ajs124
maintainers: remove fuzzy-id
fa32663 
no github account linked
@ajs124
maintainers: remove lrworth
a111cc0 
no github account linked
@ajs124
maintainers: remove chattered
fd75d8c 
no github account linked
@ajs124
maintainers: remove m3tti
143efb5 
no github account linked
@ajs124
maintainers: remove kkallio
0c35b85 
no github account linked
@ajs124
maintainers: remove miltador
d26d95d 
no github account linked
@ajs124
maintainers: remove Esteth
1bce27e 
no github account linked
@ajs124
maintainers: remove zef
17da000 
no github account linked
@ajs124
maintainers: remove lyt
d3991bc 
no github account linked
@ajs124
maintainers: remove bjg
466b147 
does not seem to have contributed since nixpkgs migrated to git
@ajs124 ajs124 force-pushed the fix/some-maintainer-handles branch from 3d79621 to 466b147 Compare June 28, 2022 23:05
@ajs124 ajs124 changed the title WIP: treewide: try to clean up maintainer-list treewide: start cleaning up maintainer-list Jun 28, 2022
@ajs124 ajs124 marked this pull request as ready for review June 28, 2022 23:37
@jonringer
Copy link
Contributor

jonringer commented Jun 28, 2022

kinda sad at seeing volth go :(

@mweinelt
Copy link
Member

mweinelt commented Jun 29, 2022

Thanks for doing the work.

@mweinelt mweinelt merged commit 3130e86 into NixOS:master Jun 29, 2022
@ajs124 ajs124 deleted the fix/some-maintainer-handles branch June 29, 2022 13:37
@rnhmjoj rnhmjoj mentioned this pull request Jan 27, 2023
Merged
@infinisil infinisil mentioned this pull request Dec 10, 2023
Closed
13 tasks
@infinisil
Copy link
Member

infinisil commented Dec 10, 2023

The users you added GitHub accounts for here should've really been asked beforehand. It's not mandatory to add that information, and users have the right to not have that be added. See the recent #272199, #273146 and #273220

This was referenced Dec 15, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mweinelt mweinelt mweinelt approved these changes

@mmahut mmahut Awaiting requested review from mmahut

@RaghavSood RaghavSood Awaiting requested review from RaghavSood

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@marsam marsam Awaiting requested review from marsam

@edwtjo edwtjo Awaiting requested review from edwtjo

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: printing Drivers, CUPS & Co. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: xfce The Xfce Desktop Environment 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ajs124 @jonringer @mweinelt @infinisil