Skip to content

Comments

ocaml-ng.ocamlPackages_4_05.lablgtk: add -fcommon workaround#178373

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
trofi:workaround-fno-common-for-ocaml-ng.ocamlPackages_4_05.lablgtk
Jun 21, 2022
Merged

ocaml-ng.ocamlPackages_4_05.lablgtk: add -fcommon workaround#178373
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
trofi:workaround-fno-common-for-ocaml-ng.ocamlPackages_4_05.lablgtk

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Jun 20, 2022

Workaround build failure on -fno-common toolchains like upstream
gcc-10. Otherwise build fails as:

ld: ml_gtktree.o:(.bss+0x0): multiple definition of
  `ml_table_extension_events'; ml_gdkpixbuf.o:(.bss+0x0): first defined here
Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Workaround build failure on -fno-common toolchains like upstream
gcc-10. Otherwise build fails as:

    ld: ml_gtktree.o:(.bss+0x0): multiple definition of
      `ml_table_extension_events'; ml_gdkpixbuf.o:(.bss+0x0): first defined here
@github-actions github-actions bot added the 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. label Jun 20, 2022
@trofi trofi mentioned this pull request Jun 20, 2022
13 tasks
@veprbl
Copy link
Member

veprbl commented Jun 21, 2022

@GrahamcOfBorg eval

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 21, 2022
@SuperSandro2000 SuperSandro2000 merged commit abc73a5 into NixOS:master Jun 21, 2022
@trofi trofi deleted the workaround-fno-common-for-ocaml-ng.ocamlPackages_4_05.lablgtk branch June 21, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants