setup.sh: use -exec rather than -execdir#177789
Merged
Conversation
13 tasks
Busybox's `find` does not support `-execdir`, so let's uses `-exec` instead, in the spirit of requiring the minimum features needed for the task.
13 tasks
9 tasks
Contributor
|
This looks quite safe to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this is untested. I will undraft when I have verified it. That will take a while (global rebuild).nix build abuildcompleted; rebuilding the rest of my userspace (should be done by morning)Description of changes
Busybox's
finddoes not support-execdir, so let's uses-execinstead, in the spirit of requiring the minimum features needed for the task. The benefit of-execdirover-execis robustness against TOCTOU (Time Of Check Time Of Use) attacks, which I believe are not a concern here.Some packages (e.g. abuild) put
busyboxinto theirnativeBuildInputs, which leads tosetup.shusingbusybox findrather than$findutils/bin/find(becausebusybox findis earlier in the$PATH). This PR will fix those packages, although it really isn't a good thing if they are inadvertently changing whichstdenv-tools are being used bysetup.sh. This PR should not be interpreted as encouraging that sort of thing.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes