Skip to content

Comments

[staging-next] v8_8_x: use python39#177302

Merged
mweinelt merged 1 commit intoNixOS:staging-nextfrom
dotlambda:v8_8_x-python39
Jun 15, 2022
Merged

[staging-next] v8_8_x: use python39#177302
mweinelt merged 1 commit intoNixOS:staging-nextfrom
dotlambda:v8_8_x-python39

Conversation

@dotlambda
Copy link
Member

Description of changes

Using Python 3.10 makes the build fail with

ImportError: cannot import name 'Mapping' from 'collections'

On staging-next Python 3.10 is now the default.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Using Python 3.10 makes the build fail with

    ImportError: cannot import name 'Mapping' from 'collections'
@dotlambda dotlambda requested a review from abbradar June 11, 2022 15:35
@ofborg ofborg bot requested review from cstrahan and matthewbauer June 11, 2022 15:43
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 11, 2022
@dotlambda dotlambda requested review from mweinelt and vcunat June 14, 2022 02:06
@mweinelt mweinelt merged commit f124f2f into NixOS:staging-next Jun 15, 2022
@dotlambda dotlambda deleted the v8_8_x-python39 branch June 15, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants