Skip to content

Comments

grsecurity: add gradm, paxctl, and pax-utils (take #2)#1771

Merged
wizeman merged 3 commits intoNixOS:masterfrom
thoughtpolice:grsec-tools
Feb 22, 2014
Merged

grsecurity: add gradm, paxctl, and pax-utils (take #2)#1771
wizeman merged 3 commits intoNixOS:masterfrom
thoughtpolice:grsec-tools

Conversation

@thoughtpolice
Copy link
Member

Per the #1765 (hopefully without GitHub eating my pull requests again).

  • I cleaned up the 'meta' info to always reside at the bottom per recommendation.
  • Per point two by @wizeman - the 'gcc' etc buildInputs seem to be required. Especially for GCC, because the Makefile for gradm is hard-coded to otherwise use /usr/bin/gcc it seems, which results in ld failing due to an impure link at the end. The makefile is a bit hacky unfortunately so IMO it's safer to properly specify all the tools it needs explicitly.

Otherwise I think this is good to go.


This adds 3 packages you might typically want with a grsec deployment.

The pieces here basically overlap some of with #1187 (which I found after I wrote my own gradm package). This also installs the udev rules for gradm.

Unlike the work by @wizeman it doesn't attempt to properly mark JIT binaries via paxctl - it only adds the packages. But I think there's no reason to hold back the packages even without this.

And pax-utils is from the Hardened Gentoo project, and includes some useful utilities (like pspax).

@wizeman
Copy link
Member

wizeman commented Feb 18, 2014

Looks good to me!

This also ensures the appropriate udev rules are installed.

Signed-off-by: Austin Seipp <[email protected]>
Signed-off-by: Austin Seipp <[email protected]>
Signed-off-by: Austin Seipp <[email protected]>
@thoughtpolice
Copy link
Member Author

@wizeman Can these get merged? I updated the packages to also properly include maintainer attributes (specifying me - I did not see you in maintainers.nix or I would have added you as well) and the correct version information in the name attribute. Like I said, my gradm package also installs correct udev rules and I've been using these packages successfully. So I believe these are ready to go, and improvements to mark binaries with paxctl can come soon afterwords (which is something I'll need).

(gradm of course requires some other specific improvements that require a NixOS module to set up /etc, but I'll be submitting something else about that soon.)

@wizeman
Copy link
Member

wizeman commented Feb 21, 2014

@thoughtpolice I will add myself as a maintainer later to all the packages I'm keeping track of.

Your patches look good to me and I am OK with getting them merged. However, I am not quite clear whether I should be merging them myself, taking into account that this is not a simple version update and only very recently I was given commit access...

@wizeman
Copy link
Member

wizeman commented Feb 21, 2014

I guess what I'm saying is that I'm not clear what are the rules for getting something merged into the repository. For example, I wonder how many reviews/reviewers are needed when adding a new package, or how many are needed for changing an existing package, ...?

@vcunat
Copy link
Member

vcunat commented Feb 22, 2014

@wizeman: no rules exist (except that stable branch is only meant for maintenance+security updates), we rely purely on judgement of each individual.

@wizeman
Copy link
Member

wizeman commented Feb 22, 2014

In that case, I think I'm going to go ahead and merge it... Even though I assume we're close to the 14.02 release, this is just adding new packages, so I think there's very little risk of regressions.

wizeman added a commit that referenced this pull request Feb 22, 2014
grsecurity: add gradm, paxctl, and pax-utils (take #2)
@wizeman wizeman merged commit 39fbd8f into NixOS:master Feb 22, 2014
@wizeman
Copy link
Member

wizeman commented Feb 22, 2014

Thanks, @thoughtpolice !

@thoughtpolice
Copy link
Member Author

Excellent, thanks! I do hope these packages are useful for the 14.02 release, and I think that they will be useful to anyone who wants to deploy grsecurity.

(Relatedly, I also hope in the future that grsecurity stable-kernel updates can be shipped to the stable branch as well, if they are not already.)

@thoughtpolice thoughtpolice deleted the grsec-tools branch March 4, 2014 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants