Skip to content

llvmPackages_14: Fix remaining broken gnu-install-dirs patches#176925

Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom
Ericson2314:llvm-14-fix-broken-gnu-install-dirs
Jun 9, 2022
Merged

llvmPackages_14: Fix remaining broken gnu-install-dirs patches#176925
Ericson2314 merged 1 commit intoNixOS:masterfrom
Ericson2314:llvm-14-fix-broken-gnu-install-dirs

Conversation

@Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Jun 8, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 requested a review from matthewbauer as a code owner June 8, 2022 16:44
@ofborg ofborg bot requested review from 7c6f434c, dtzWill and lovek323 June 8, 2022 16:52
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 8, 2022
@Ericson2314 Ericson2314 mentioned this pull request Jun 8, 2022
Merged
13 tasks
@Ericson2314
Copy link
Member Author

Ericson2314 commented Jun 9, 2022

@primeos is that ❤️ approval to merge? :)

primeos
primeos approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda, I didn't do any testing but there shouldn't be any reason not to merge this anyway (as this only improves/fixes things - assuming that the libcxx change doesn't cause a severe regression).

@Ericson2314 Ericson2314 merged commit 9458f80 into NixOS:master Jun 9, 2022
@Ericson2314 Ericson2314 deleted the llvm-14-fix-broken-gnu-install-dirs branch June 9, 2022 20:19
@github-actions github-actions bot mentioned this pull request Jun 9, 2022
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2022

Successfully created backport PR #177086 for release-22.05.

@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@lovek323 lovek323 Awaiting requested review from lovek323

@dtzWill dtzWill Awaiting requested review from dtzWill

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

1 more reviewer

@primeos primeos primeos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ericson2314 @primeos @rrbutani