Skip to content

treewide: remove usage of runCommandNoCC aliases#176723

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
SuperSandro2000:runCommandNoCC
Jun 7, 2022
Merged

treewide: remove usage of runCommandNoCC aliases#176723
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
SuperSandro2000:runCommandNoCC

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jun 7, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 7, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 7, 2022
siraben
siraben approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@siraben siraben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. What was the original purpose of runCommandNoCC and why was it aliased to runCommand?

@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Jun 7, 2022

LGTM. What was the original purpose of runCommandNoCC

To have a runCommand build with stdenvNoCC so that it does not depend on gcc.

and why was it aliased to runCommand?

The move to aliases.nix was done in #134225. runCommandNoCC was originally introduced in 97bfc2f with an alias to runCommand. Back then there was probably no good aliases way to do this.

@SuperSandro2000 SuperSandro2000 merged commit 2d39908 into NixOS:master Jun 7, 2022
@SuperSandro2000 SuperSandro2000 deleted the runCommandNoCC branch June 7, 2022 17:03
mightyiam added a commit to mightyiam/nix-unit that referenced this pull request Nov 5, 2025
@mightyiam
runCommandNoCC -> runCommand
9631cc5 
NixOS/nixpkgs#134225
NixOS/nixpkgs#176723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alyssais alyssais alyssais approved these changes

@siraben siraben siraben approved these changes

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SuperSandro2000 @alyssais @siraben